Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ComponentUseLocalHostAsDefaultHost() #3306

Closed
diranged opened this issue Sep 26, 2024 · 7 comments · Fixed by #3334
Closed

Remove ComponentUseLocalHostAsDefaultHost() #3306

diranged opened this issue Sep 26, 2024 · 7 comments · Fixed by #3334
Labels
bug Something isn't working discuss-at-sig This issue or PR should be discussed at the next SIG meeting

Comments

@diranged
Copy link

Component(s)

collector

What happened?

Description

The ComponentUseLocalHostAsDefaultHost() function should be removed at this point... the operator forces the component.UseLocalHostAsDefaultHost flag to be added. The problem is that in the OTEL Collector 0.110.0, that flag is no longer settable:

Error: invalid argument "+processor.resourcedetection.hostCPUSteppingAsString,+exporter.prometheusremotewritexporter.RetryOn429,-component.UseLocalHostAsDefaultHost" for "--feature-gates" flag: feature gate "component.UseLocalHostAsDefaultHost" is stable, can not be disabled

Kubernetes Version

1.30.0

Operator version

0.109.0

Collector version

1.111.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Log output

No response

Additional context

No response

@diranged diranged added bug Something isn't working needs triage labels Sep 26, 2024
@jaronoff97
Copy link
Contributor

this should be part of our next release, cc @frzifus would you be able to do this to close #3126 as well?

@frzifus
Copy link
Member

frzifus commented Sep 26, 2024

yes!

@ryanmt
Copy link

ryanmt commented Sep 26, 2024

Is there any way to prevent this feature flag from being added to the produced resources w/o a new release? I'm trying to overcome an issue similar to this one for the helm chart from the install manifests. open-telemetry/opentelemetry-helm-charts#1339

image

@frzifus frzifus added discuss-at-sig This issue or PR should be discussed at the next SIG meeting and removed needs triage labels Sep 26, 2024
@jaronoff97
Copy link
Contributor

@ryanmt we will need to do a new release as that's how the images get published, though i guess you could use the image from main. We haven't released 0.110.0 yet, so i would recommend not misaligning those versions.

@henrikrexed
Copy link

Hi,
i'm having the same issue , i forced to use a collector v 0.110 to get the latest functions of the transform processor.
When would the feature flalg UseLocalHostAsdeFualthost would be removed and when is the next release of the operator planned?

@jaronoff97
Copy link
Contributor

@henrikrexed @frzifus is on it right now and will be done hopefully by EOW this week.

@odubajDT
Copy link

odubajDT commented Oct 4, 2024

Related issue Dynatrace/dynatrace-otel-collector#311. The feature flag was fully moved to stable in OTel upstream, waiting for a new upstream release to backport the changes to dynatrace-otel-collector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discuss-at-sig This issue or PR should be discussed at the next SIG meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants