-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 0.0.0.0 as otlp receiver default address #3325
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
force-pushed
the
add/receiver_defaults
branch
from
October 4, 2024 17:43
a8ddba7
to
02cb882
Compare
jaronoff97
reviewed
Oct 4, 2024
frzifus
force-pushed
the
add/receiver_defaults
branch
4 times, most recently
from
October 4, 2024 22:36
dcbad5b
to
9cd5174
Compare
frzifus
commented
Oct 4, 2024
frzifus
force-pushed
the
add/receiver_defaults
branch
2 times, most recently
from
October 4, 2024 23:05
b5ec8f0
to
e88e863
Compare
frzifus
force-pushed
the
add/receiver_defaults
branch
2 times, most recently
from
October 5, 2024 00:36
42c18da
to
d3f8a9f
Compare
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
add/receiver_defaults
branch
from
October 5, 2024 00:38
d3f8a9f
to
2526626
Compare
jaronoff97
reviewed
Oct 5, 2024
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
add/receiver_defaults
branch
from
October 6, 2024 00:33
3d25d62
to
0b2030e
Compare
jaronoff97
reviewed
Oct 6, 2024
pavolloffay
reviewed
Oct 7, 2024
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
add/receiver_defaults
branch
from
October 7, 2024 12:18
0b2030e
to
edf8554
Compare
Add tests and simplify some logic
Signed-off-by: Benedikt Bongartz <[email protected]>
jaronoff97
approved these changes
Oct 7, 2024
pavolloffay
approved these changes
Oct 7, 2024
jvoravong
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change sets the otlp receiver endpoint 0.0.0.0 as default, unless otherwise configured by the user.
This PR does not change the default endpoint for other receivers.
The following steps:
Link to tracking Issue(s):
Testing:
Documentation: