Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 0.0.0.0 as otlp receiver default address #3325

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Oct 4, 2024

Description:

This change sets the otlp receiver endpoint 0.0.0.0 as default, unless otherwise configured by the user.

This PR does not change the default endpoint for other receivers.

The following steps:

  • Add default addresses for other receivers
  • Remove ComponentUseLocalHostAsDefaultHost feature gate flag

Link to tracking Issue(s):

Testing:

Documentation:

@frzifus frzifus force-pushed the add/receiver_defaults branch from a8ddba7 to 02cb882 Compare October 4, 2024 17:43
apis/v1beta1/config.go Outdated Show resolved Hide resolved
internal/components/multi_endpoint.go Outdated Show resolved Hide resolved
internal/components/generic_parser.go Show resolved Hide resolved
@frzifus frzifus force-pushed the add/receiver_defaults branch 4 times, most recently from dcbad5b to 9cd5174 Compare October 4, 2024 22:36
@frzifus frzifus force-pushed the add/receiver_defaults branch 2 times, most recently from b5ec8f0 to e88e863 Compare October 4, 2024 23:05
@frzifus frzifus changed the title wip Use 0.0.0.0 as otlp receiver default address Oct 4, 2024
@frzifus frzifus force-pushed the add/receiver_defaults branch 2 times, most recently from 42c18da to d3f8a9f Compare October 5, 2024 00:36
Signed-off-by: Benedikt Bongartz <[email protected]>
@frzifus frzifus force-pushed the add/receiver_defaults branch from d3f8a9f to 2526626 Compare October 5, 2024 00:38
@frzifus frzifus marked this pull request as ready for review October 5, 2024 01:11
@frzifus frzifus requested a review from a team as a code owner October 5, 2024 01:11
@frzifus frzifus requested a review from jaronoff97 October 5, 2024 01:11
apis/v1beta1/config.go Outdated Show resolved Hide resolved
apis/v1beta1/config.go Outdated Show resolved Hide resolved
internal/components/generic_parser.go Outdated Show resolved Hide resolved
internal/components/multi_endpoint.go Show resolved Hide resolved
internal/components/component.go Outdated Show resolved Hide resolved
Signed-off-by: Benedikt Bongartz <[email protected]>
@frzifus frzifus force-pushed the add/receiver_defaults branch from 3d25d62 to 0b2030e Compare October 6, 2024 00:33
@frzifus frzifus requested a review from jaronoff97 October 6, 2024 00:34
apis/v1beta1/config.go Outdated Show resolved Hide resolved
@frzifus frzifus force-pushed the add/receiver_defaults branch from 0b2030e to edf8554 Compare October 7, 2024 12:18
Signed-off-by: Benedikt Bongartz <[email protected]>
@jaronoff97 jaronoff97 merged commit 8eb13f1 into open-telemetry:main Oct 7, 2024
33 checks passed
@frzifus frzifus deleted the add/receiver_defaults branch October 7, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants