Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract generated code into separate repos/packages #553

Closed
tidal opened this issue Jan 23, 2022 · 2 comments
Closed

Extract generated code into separate repos/packages #553

tidal opened this issue Jan 23, 2022 · 2 comments
Labels
help wanted This issue is looking for someone to work on it refactoring Doesn't change behavior, but improves performance or maintainability or removes technical debt. small small sized task

Comments

@tidal
Copy link
Member

tidal commented Jan 23, 2022

Generated code (proto, thrift) should be extracted into separated repositories, so it can automatically be updated and follow versioning of the upstream.
The generated packages can then be required by the library.
@stale
Copy link

stale bot commented Feb 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 24, 2022
@tidal tidal added help wanted This issue is looking for someone to work on it good first issue Good for newcomers small small sized task refactoring Doesn't change behavior, but improves performance or maintainability or removes technical debt. and removed wontfix This will not be worked on labels Mar 10, 2022
@tidal tidal removed the good first issue Good for newcomers label Jul 12, 2022
@brettmc
Copy link
Collaborator

brettmc commented Sep 20, 2022

Done in #682

@brettmc brettmc closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted This issue is looking for someone to work on it refactoring Doesn't change behavior, but improves performance or maintainability or removes technical debt. small small sized task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tidal @brettmc