Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf generation broken #660

Closed
brettmc opened this issue Apr 13, 2022 · 1 comment · Fixed by #665
Closed

protobuf generation broken #660

brettmc opened this issue Apr 13, 2022 · 1 comment · Fixed by #665
Assignees
Labels
bug Something isn't working pinned Will not be removed by stalebot

Comments

@brettmc
Copy link
Collaborator

brettmc commented Apr 13, 2022

Recently, our protobuf generation process (make protobuf) has stopped working, due to the image we use (socialpoint/protobuf-tools) no longer being available on docker hub.
It looks like https://docs.buf.build/introduction is the new way to generate APIs, so this could be investigated as a possible solution.

Steps to reproduce
Run make protobuf

What is the expected behavior?
Regenerated protobuf API files are produced

What is the actual behavior?
Failed to pull image

@brettmc brettmc added bug Something isn't working pinned Will not be removed by stalebot labels Apr 13, 2022
@brettmc brettmc self-assigned this Apr 23, 2022
@brettmc
Copy link
Collaborator Author

brettmc commented Apr 23, 2022

It looks like the opentelemetry-proto repo is already set up to generate language-specific protobuf code... make gen-php looks to generate sensible output, and it might be as simple as swapping our current build process over to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned Will not be removed by stalebot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant