Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP Factory Decoraters and Dependency Resolvers #731

Closed
wants to merge 20 commits into from

Conversation

tidal
Copy link
Member

@tidal tidal commented Jun 27, 2022

  • Adds Decoraters for HTTP Request/Response Factories which autmatically inject/extract Carrier information upon Request/Response creation
  • Adds Resolvers for HTTP dependencies for future use in Exporter Client (etc.) rework.

related:

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #731 (a784918) into main (4c10268) will increase coverage by 0.74%.
The diff coverage is 100.00%.

❗ Current head a784918 differs from pull request most recent head fc03377. Consider uploading reports for the commit fc03377 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #731      +/-   ##
============================================
+ Coverage     82.49%   83.24%   +0.74%     
- Complexity     1263     1315      +52     
============================================
  Files           145      155      +10     
  Lines          3125     3235     +110     
============================================
+ Hits           2578     2693     +115     
+ Misses          547      542       -5     
Flag Coverage Δ
7.4 83.25% <100.00%> (+0.76%) ⬆️
8.0 83.30% <100.00%> (+0.74%) ⬆️
8.1 83.30% <100.00%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ommon/Adapter/HttpDiscovery/DependencyResolver.php 100.00% <100.00%> (ø)
...n/Adapter/HttpDiscovery/HttpPlugClientResolver.php 100.00% <100.00%> (ø)
...n/Adapter/HttpDiscovery/MessageFactoryResolver.php 100.00% <100.00%> (ø)
...Common/Adapter/HttpDiscovery/PsrClientResolver.php 100.00% <100.00%> (ø)
.../Common/Http/Psr/Message/FactoryDecoratorTrait.php 100.00% <100.00%> (ø)
src/SDK/Common/Http/Psr/Message/MessageFactory.php 100.00% <100.00%> (ø)
...ommon/Http/Psr/Message/RequestFactoryDecorator.php 100.00% <100.00%> (ø)
.../Http/Psr/Message/RequestFactoryDecoratorTrait.php 100.00% <100.00%> (ø)
...mmon/Http/Psr/Message/ResponseFactoryDecorator.php 100.00% <100.00%> (ø)
...Http/Psr/Message/ServerRequestFactoryDecorator.php 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c10268...fc03377. Read the comment docs.

@tidal tidal marked this pull request as ready for review June 27, 2022 14:19
@tidal tidal marked this pull request as draft June 28, 2022 18:54
@tidal
Copy link
Member Author

tidal commented Jul 2, 2022

Closing in favor of: #744

@tidal tidal closed this Jul 2, 2022
@tidal tidal deleted the http branch July 2, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant