Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor use of changedir in tox.ini #3744

Closed
ocelotl opened this issue Mar 1, 2024 · 0 comments · Fixed by #3745
Closed

Refactor use of changedir in tox.ini #3744

ocelotl opened this issue Mar 1, 2024 · 0 comments · Fixed by #3745
Labels
bug Something isn't working

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Mar 1, 2024

This is necessary to solve an issue with #3742:

In order to run lint we need responses, which is present here. responses was previously in the pyproject.toml file but only as a test dependency.

So, I am fixing this by running lint with pinned dependencies by using a requirements file (which we should do anyways). The problem is that these files right now have lines like these at the end:

-e ../../../opentelemetry-proto
-e ../../../exporter/opentelemetry-exporter-otlp-proto-common
-e ../../../exporter/opentelemetry-exporter-otlp-proto-http

The change of directories at the beginning of every one of those lines is necessary because we have changedir in the tox.ini file. But when lint is executed, there is no corresponding changedir section for lint so, installation fails because the dependency paths cannot be resolved.

To solve this issue, it is necessary to remove the changedir section from tox.ini and instead use a separate pytest command with the complete path of the test folder for every component.

@ocelotl ocelotl added the bug Something isn't working label Mar 1, 2024
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 1, 2024
@ocelotl ocelotl changed the title Remove changedir from tox Refactor use of changedir in tox.ini Mar 2, 2024
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 2, 2024
ocelotl added a commit that referenced this issue Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant