Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve efficiency of ETW metrics exporter #134

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Improve efficiency of ETW metrics exporter #134

wants to merge 12 commits into from

Conversation

mattbodd
Copy link
Contributor

@mattbodd mattbodd commented Dec 3, 2024

Fixes #104
Design Decisions:

  • Follow .Net and C++ implementations and use helper methods to serialize fragments of metric points into a coherent, exportable buffer
  • Construct a new ResourceMetrics for each metric point and serialize each into an exportable buffer

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.76636% with 27 lines in your changes missing coverage. Please review.

Project coverage is 55.2%. Comparing base (0c3771a) to head (6f3e6f1).

Files with missing lines Patch % Lines
opentelemetry-etw-metrics/src/exporter/mod.rs 74.7% 27 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #134     +/-   ##
=======================================
- Coverage   55.4%   55.2%   -0.2%     
=======================================
  Files         39      39             
  Lines       6098    5957    -141     
=======================================
- Hits        3381    3291     -90     
+ Misses      2717    2666     -51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cijothomas
cijothomas reviewed Dec 14, 2024
View reviewed changes
opentelemetry-etw-metrics/benches/exporter.rs

use criterion::{criterion_group, criterion_main, Criterion};

fn export() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not measuring the cost of export - it is creating new runtime, create meter provider, meter, instrument, record 10,000 measurements, flush, and drop...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Etw-Metrics - Improvements required
2 participants
@mattbodd @cijothomas