Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Please release an update to opentelemetry-aws that depends on the the latest opentelemetry #110

Closed
dcormier opened this issue Sep 17, 2024 · 13 comments
Labels
enhancement New feature or request

Comments

@dcormier
Copy link

Related Problems?

No response

What component are you working with?

No response

Describe the solution you'd like:

It would be nice to be able to use opentelemetry-aws with the latest version of opentelemetry (0.25). But opentelemetry-aws implements opentelemetry::propagation::TextMapPropagator from the previous version (0.24).

Considered Alternatives

I've considered using a [patch] directive to use the code currently on github, but I'd rather use a released version.

Additional Context

No response

@dcormier dcormier added the enhancement New feature or request label Sep 17, 2024
@nakedible-p
Copy link

I can see a release is cooking from the commits, but please prioritize this. It's preventing updating opentelemetry in a number of places.

@cijothomas
Copy link
Member

@lalitb is pushing releases to crates.io. (He was travelling, hence some delay!).

Also, we are looking for someone to own the component. Is that something you can take ownership of? We don't have a written set of policies yet to manage ownerships, but something we expect to have in the near future.

@nakedible-p
Copy link

Travel is an excellent excuse. Hopefully they had a nice trip!

I could consider ownership, but will need to think about it. At the moment this is very light on functionality, but there are many things that should be added.

@lalitb
Copy link
Member

lalitb commented Sep 26, 2024

Some issue with the publishing (running cargo publish),

   Uploading opentelemetry-aws v0.13.0 (/tmp/opentelemetry-rust-contrib/opentelemetry-aws)
error: failed to publish to registry at https://crates.io

Caused by:
  the remote server responded with an error (status 403 Forbidden): this crate exists but you don't seem to be an owner. If you believe this is a mistake, perhaps you need to accept an invitation to be an owner before publishing.

Both me and @cijothomas are getting this error.
@TommyCpp @hdost Do you know what it could be? Could it be somwhat related to the recent accidental deletion of the OpenTelemetry Github team account?

@lalitb
Copy link
Member

lalitb commented Sep 26, 2024

created issue with the crates.io:

rust-lang/crates.io#9525
rust-lang/crates.io#9524

@TommyCpp
Copy link
Contributor

Could it be somwhat related to the recent accidental deletion of the OpenTelemetry Github team account?

It could be. Maybe we try to remove the group from create.io and add it again?

@lalitb
Copy link
Member

lalitb commented Sep 26, 2024

It could be. Maybe we try to remove the group from create.io and add it again?

Yes tried that. It gives HTTP 500 with that - rust-lang/crates.io#9524

@nakedible-p
Copy link

@cijothomas Could I get some more info about the ways of working for maintaining the aws crate?

Alternatively, do you want to especially keep the create as part of opentelemetry-rust-contrib? Or could it make sense to just publish this separately? I'm open to multiple options.

@lalitb
Copy link
Member

lalitb commented Sep 30, 2024

@open-telemetry/rust-maintainers - based on the comment in rust-lang/crates.io#9524, it seems we can't use this maintainer group name be used as crate owner. Should we raise a request in otel-community to rename it ?

@cijothomas
Copy link
Member

@cijothomas Could I get some more info about the ways of working for maintaining the aws crate?

Alternatively, do you want to especially keep the create as part of opentelemetry-rust-contrib? Or could it make sense to just publish this separately? I'm open to multiple options.

It is totally acceptable to keep the component in this repo. Contrib repo is generally the right place to host components that are outside of opentelemetry specification. Vendor specific components can be hosted here, assuming there is one(or more) person who can commit to maintaining (fixing bugs, responding to issues etc.) it. It maybe possible for AWS specific components be hosted by AWS itself.

@nakedible-p
Copy link

@cijothomas First to be clear, I'm in no way affiliated with AWS, I'm just a user of the component.

Secondly, my worry is that this repo has issues that relate to the wider set of contrib components here than just the AWS one. I fear that some general issue is going to prevent me from publishing a new version of "opentelemetry-aws", due to some totally unrelated stuff. It's not necessarily a blocker, but I'd sleep better if I know that when I "maintain" a component, I actually have control over it. So my question wasn't that is it fine to host it here, but my question is that is it fine to host it elsewhere.

@cijothomas
Copy link
Member

@cijothomas First to be clear, I'm in no way affiliated with AWS, I'm just a user of the component.

Secondly, my worry is that this repo has issues that relate to the wider set of contrib components here than just the AWS one. I fear that some general issue is going to prevent me from publishing a new version of "opentelemetry-aws", due to some totally unrelated stuff. It's not necessarily a blocker, but I'd sleep better if I know that when I "maintain" a component, I actually have control over it. So my question wasn't that is it fine to host it here, but my question is that is it fine to host it elsewhere.

Every component is independently managed, version and released. There should not be a scenario where one component affects another. If that occurs, it is on the maintainers of the repo to take care of that.

when I "maintain" a component, I actually have control over it

You have reasonable amount of control. But ultimately, maintainers of this repo only can do the merge button press and do releases.

@cijothomas
Copy link
Member

So my question wasn't that is it fine to host it here, but my question is that is it fine to host it elsewhere.

We'll be posting an issue to invite owners for each component in this repo. Components without response in a reasonable amount of time will be removed from the repo, and anyone is free to take ownership here or take elsewhere. (there aren't many components now in this repo, so it is not yet a high priority to find and assign owners. But this is definitely something we plan to do in near future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants