Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coreLib desugaring #25

Closed
LikeTheSalad opened this issue Nov 8, 2023 · 3 comments
Closed

Update coreLib desugaring #25

LikeTheSalad opened this issue Nov 8, 2023 · 3 comments

Comments

@LikeTheSalad
Copy link

Google's added support for java.util.Base64 in its latest corelib version. However, it seems like gummy-bears-api-21 version 0.6.1 isn't aware of that change because it complains when it finds usages of java.util.Base64 in the codebase.

@ogolberg
Copy link
Member

ogolberg commented Nov 8, 2023

This is on my radar, but I don't have a firm timeline for the upgrade.

As of 2.x, the desugaring libraries are structured a bit differently to support different flavors of desugaring (full, minimal, nio- see https://maven.google.com/web/index.html?q=desugar#com.android.tools:desugar_jdk_libs_configuration). Upgrading will require a nontrivial amount of work to parse the configuration from their jars to select the signatures that should be included in each flavor.

@LikeTheSalad
Copy link
Author

I see, it does seem like it's gotten a lot more complicated for sure 😞

I'm pretty sure that dealing with the fragmentation into multiple libs is going to be a lot of work, although in case it makes things a little easier, just wanted to mention that probably a "good-enough" option in the meantime could be addressing only the "full" library, which I guess should be the closest option to the 1.x lib before the fragmentation into multiple ones was carried out.

@ogolberg
Copy link
Member

That's fair. Addressed in #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants