-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @context to schemas #64
Comments
Hi Andrew. I agree that the schemas should resolve in valid URIs ( The As far as I understood the I would like to discuss this with you and Oli in more detail. We should schedule a meeting for this asap. What do you think? |
Hi Lyuba, I'd be happy to discuss this in more detail with you and Oli. A few comments on your reply, in the meantime (-: JSON schema documents can be written as JSON-LD, it seems (https://www.w3.org/2019/wot/json-schema). My feeling is that adding the |
This is json-schema draft 10. We used draft 7 until now (that was the newest one when we started, and I think that wasn't an option for this draft version). I'm glad to revise the draft 10 option for openMINDS v3, especially if it makes the json-LD conversion more simple. I'll have a look at it. So far @olinux : are you up for a discussion about this? |
Hey. If I understood this now correctly the draft your referring to is not from https://json-schema.org. I guess it will therefore not pass any standard json-schema validation tool. Also : (from my point of view as, I guess, a naive programmer) the schemas of this draft do not look more simple to me, but way more complicated to read... I'm glad to be shown otherwise though ;) Let's wait for Oli's comment and then schedule a meeting for this. My personal opinion: for now (also time wise for the integration) I would like to stick to what I've done so far which has proven to work with v1. Nonetheless I would like to discuss this now, to see if I overestimate a possible revision of all the work/discussion that was done already. Thanks for bringing it up :) |
Seems like we are not the only ones discussing this: |
After some more discussions with @olinux I would like to implement for all schemas and their properties links to other related schema definitions, but not over the typical On the one hand, because this allows for multiple relations to be made to the same term. On the other hand, because in most cases I'd like to prioritize our definitions and context of the terms. I suggest to do the following: Add to objects (schemas) and properties the key @olinux does this fit with what we discussed? |
@lzehl sure. I never understood the motivation for choosing JSON schema over SHACL, but that ship has long sailed... |
I'm closing this issue now. We'll include the references to other schemas or schema properties in the vocabulary (to keep the schema templates light for the untrained user). |
I think all terms used in openMINDS should resolve to valid URIs. Probably the easiest way to implement this is to make the schemas JSON-LD docs. At the least, we should add a @context field to each document, e.g.
The text was updated successfully, but these errors were encountered: