Add python bindings #188
Add python bindings #188
Conversation
tiltingpenguin
force-pushed
the
python-bindings
branch
2 times, most recently
from
373bc78 to
e696db2
Compare
tiltingpenguin
force-pushed
the
python-bindings
branch
2 times, most recently
from
b95d4c9 to
d5a0544
Compare
tiltingpenguin
force-pushed
the
python-bindings
branch
from
d5a0544 to
26db59d
Compare
|
Nice ! I am missing some docu like:
Testcases would also be nice. Perhaps you find a useful way for it. But docu is really required for the python libeconf user. |
tiltingpenguin
force-pushed
the
python-bindings
branch
from
bbfcd10 to
39ccacd
Compare
| from enum import Enum | ||
| from dataclasses import dataclass | ||
| from typing import * | ||
| from ctypes import * |
There was a problem hiding this comment.
Not now. But in a future PR we should remove this and export the specific symbols.
| c_key = _encode_str(key) | ||
| if not isinstance(value, float): | ||
| raise TypeError('"value" parameter must be of type float') | ||
| c_value = c_double(value) |
There was a problem hiding this comment.
Do we need here some approach for a "_ensure_valid_float(value)"
There was a problem hiding this comment.
No, because floats are saved as an exponentiation so we don't have to worry about the overflow. The typecheck should be enough
There was a problem hiding this comment.
Uhmm no. The exponentiation is because IEEE 754. In any case should not be required because a Python float is a C double:
>>> sys.float_info
sys.float_info(max=1.7976931348623157e+308, max_exp=1024, max_10_exp=308, min=2.2250738585072014e-308, min_exp=-1021, min_10_exp=-307, dig=15, mant_dig=53, epsilon=2.220446049250313e-16, radix=2, rounds=1)
The max match the one that from C and C++
tiltingpenguin
force-pushed
the
python-bindings
branch
from
07625ca to
e8ad743
Compare
tiltingpenguin
force-pushed
the
python-bindings
branch
from
e8ad743 to
5fb87cc
Compare
This PR adds python bindings for libeconf to be included in the library