Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixing completion stats break with new reasoning tokens release #1555

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfixing completion stats break with new reasoning tokens release #1555

wants to merge 1 commit into from

Conversation

lucapericlp
Copy link

@lucapericlp lucapericlp commented Sep 13, 2024 •
edited
Loading

Fixes #1556

Note for reviewers, I've removed the template given that it was strictly related to evals.

I've not added any test coverage given the lack of it in this repo.

@lucapericlp lucapericlp mentioned this pull request Sep 13, 2024
Open
@sjadler2004
Copy link
Collaborator

Thank you for trying to address this! I still get the same error unfortunately, e.g., when running oaieval gpt-4-32k 2d_movement.

I'm going to put the usage-token stats inside of a try: for now, so that this bug does not disrupt the evals completing properly.

@sjadler2004
Copy link
Collaborator

#1560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-openai andrew-openai Awaiting requested review from andrew-openai andrew-openai is a code owner

@etr2460 etr2460 Awaiting requested review from etr2460 etr2460 is a code owner

@katyhshi katyhshi Awaiting requested review from katyhshi katyhshi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

o1 release breaks token usage stats
2 participants
@lucapericlp @sjadler2004