Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msingh openai rag with vision #1561

Merged
merged 15 commits into from
Nov 13, 2024
Merged

Conversation

msingh-openai
Copy link
Contributor

Summary

Cookbook that demonstrates setup and implementation of a Pinecone RAG solution for questing and answering using GPR-4o vision modality.


For new content

When contributing new content, read through our contribution guidelines, and mark the following action items as completed:

  • I have added a new entry in registry.yaml (and, optionally, in authors.yaml) so that my content renders on the cookbook website.
  • I have conducted a self-review of my content based on the contribution guidelines:
    • Relevance: This content is related to building with OpenAI technologies and is useful to others.
    • Uniqueness: I have searched for related examples in the OpenAI Cookbook, and verified that my content offers new insights or unique information compared to existing documentation.
    • Spelling and Grammar: I have checked for spelling or grammatical mistakes.
    • Clarity: I have done a final read-through and verified that my submission is well-organized and easy to understand.
    • Correctness: The information I include is correct and all of my code executes successfully.
    • Completeness: I have explained everything fully, including all necessary references and citations.

We will rate each of these areas on a scale from 1 to 4, and will only accept contributions that score 3 or higher on all areas. Refer to our contribution guidelines for more details.

@msingh-openai
Copy link
Contributor Author

Added Kevin as reviewer

" `PINECONE_API_KEY=your-api-key-here`. \n",
" 2. Install `pip install python-dotenv` to read the API Key from the .env file. \n",
"\n",
"**Creat2 the Pinecone Index** \n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "Create"

Copy link
Contributor

@alwell-kevin alwell-kevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

Notes that I generally agree with from AI Collaboration below.

•	Title and Introduction: Simplify title; consider breaking up dense introductory text.
•	Structure: Well-organized steps, but consistent labeling (e.g., Step 1, Step 2) would improve navigation.
•	Code Clarity: Functions are clear; add brief in-line comments on key parameters, e.g., get_vision_response.
•	Error Handling: Good use of error handling in key functions; add API error output for improved debugging.
•	Visual Output: Include sample visual interpretations to verify fidelity; mention limitations for complex visuals especially tabular data.
•	Performance Notes: Add early guidance on cost and latency for vision modality use.
•	Grammar: Minor typo in markdown, e.g., “Creat2” instead of “Create”.

@msingh-openai msingh-openai merged commit 2b48f37 into main Nov 13, 2024
@msingh-openai msingh-openai deleted the msingh-openai-RAG-with-vision branch November 13, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants