Changing the REDIS_PASSWORD leads to an error while deploying

[scali]

While trying to deploy a fresh install of operator v2.1.0, I got issue trying to change the Redis Password

I try to change the password from file overlays/1-namespaced/patches/redis.secret.yaml

Here are the steps to reproduce :

1. Generate a new password :

# Generate a new password
$ echo MyPasswordChanged123 | base64
$ TXlQYXNzd29yZENoYW5nZWQxMjMK

2. Update overlays/1-namespaced/patches/redis.secret.yaml :

apiVersion: v1
kind: Secret
metadata:
  name: redis
type: Opaque
data:
-  # IMPORTANT: replace this password!
-  #redis-password: bXlTZWN1cmVQYXNzd29yZDEy
+  redis-password: TXlQYXNzd29yZENoYW5nZWQxMjMK

3. Deploy using as the documentation says :

kustomize build .  | kubectl apply -f - --server-side

This leads to an error on Redis-Sentinel pod while deploying the operator on kubernetes :

Startup probe failed: NOAUTH Authentication required. AUTH failed: WRONGPASS invalid username-password pair or user is disabled.

Note

If i don't change the file overlays/1-namespaced/patches/redis.secret.yaml the deployment is working.

[scali]

there is maybe a link with #44

[LEDfan]

Hi, thank you for opening this issue!
If you change the password after initial deployment, Redis will not notice this change and therefore continues to use the old password. As you experiences this can cause a broken setup. Underlying we use the bitnami helm chart and they mention this is not possible:

NOTE: Once this chart is deployed, it is not possible to change the application's access credentials, such as usernames or passwords, using Helm. To change these application credentials after deployment, delete any persistent volumes (PVs) used by the chart and re-deploy it, or use the application's built-in administrative tools if available.

https://github.com/bitnami/charts/blob/main/bitnami/redis/README.md

Since this isn't obvious, I documented this in our repo and also added instructions on how to change it here: https://github.com/openanalytics/shinyproxy-operator/tree/master/docs/deployment#changing-redis-password