Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage-adapter API: fix all implementations to reject zero length files #87

Open
pdowler opened this issue Mar 10, 2020 · 1 comment
Open

storage-adapter API: fix all implementations to reject zero length files #87

pdowler opened this issue Mar 10, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@pdowler
Copy link
Member

pdowler commented Mar 10, 2020 •
edited
Loading

StorageMetadata constructor now checks that contentLength > 0.

StorageAdapter.put() specifies that zero-length files are not allowed ( IllegalArgumentException). Implementations must throw and should auto-cleanup if possible.
@pdowler pdowler added the bug Something isn't working label Mar 10, 2020
@pdowler pdowler added the alpha label May 27, 2020
@pdowler pdowler removed the alpha label Jul 15, 2020
@pdowler pdowler added the beta must be resolved before ops start deploying label Sep 21, 2020
@pdowler pdowler added gamma must be resolved before production deployment and removed beta must be resolved before ops start deploying labels Oct 5, 2020
@pdowler
Copy link
Member Author

pdowler commented Feb 24, 2022

cadc-storage-adapter-test-0.4.1 includes a test for this; currently active adapters pass.

@pdowler pdowler closed this as completed Feb 24, 2022
@exalate-issue-sync exalate-issue-sync bot reopened this Apr 18, 2022
@pdowler pdowler removed the gamma must be resolved before production deployment label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pdowler