Added unit tests around config and other minor tweaks. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chbalzer
reviewed
Jan 24, 2019
chbalzer
reviewed
Jan 24, 2019
src/main/java/com/opencredo/connect/venafi/tpp/log/TppLogSourceConfig.java
Outdated
Show resolved
Hide resolved
chbalzer
reviewed
Jan 24, 2019
src/main/java/com/opencredo/connect/venafi/tpp/log/TppLogSourceConnector.java
Outdated
Show resolved
Hide resolved
chbalzer
reviewed
Jan 24, 2019
src/main/java/com/opencredo/connect/venafi/tpp/log/TppLogSourceTask.java
Show resolved
Hide resolved
chbalzer
reviewed
Jan 24, 2019
| Map<String, Object> sourceOffset = new HashMap<>(); | ||
| sourceOffset.put(LAST_READ, lastRead); | ||
| sourceOffset.put(LAST_API_OFFSET, apiOffset); | ||
| return sourceOffset; | ||
| } | ||
|
|
||
| List<EventLog> getTppLogs(String token, String date, int offset) { | ||
| List<EventLog> getTppLogs(String token, String date, long offset) { |
There was a problem hiding this comment.
we should probably look at the whole file and figure out where to best auto-box and auto-unbox the Long...
chbalzer
reviewed
Jan 24, 2019
src/test/java/com/opencredo/connect/venafi/tpp/log/TppLogSourceConfigTest.java
Show resolved
Hide resolved
chbalzer
reviewed
Jan 24, 2019
src/test/java/com/opencredo/connect/venafi/tpp/log/TppLogSourceConfigTest.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: rufusfnash <[email protected]>
…ncredo/kafka-connect-venafi-tpp into config_def_test_and_validate
chbalzer
previously requested changes
Jan 24, 2019
src/test/java/com/opencredo/connect/venafi/tpp/log/TppLogSourceConfigTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/opencredo/connect/venafi/tpp/log/TppLogSourceConfigTest.java
Outdated
Show resolved
Hide resolved
| props.put(BASE_URL_CONFIG, "https://localhost:443"); | ||
| props.put(USERNAME_CONFIG, "placeholder_username"); | ||
| props.put(PASSWORD_CONFIG, "placeholder_password"); | ||
| return props; |
There was a problem hiding this comment.
If Guava is on the path, we could do return ImmutableMap.of()...; - looks nicer and ensures nobody messes with our config... 😇
| } | ||
|
|
||
| private void given_this_is_overriden_with(String key, Object value, Map<String, Object> props) { | ||
| props.put(key, value); |
There was a problem hiding this comment.
wrap in assertNotNull()? (I seem to remember put will return an old value, if any?
There was a problem hiding this comment.
True but I think you're then testing the test more than the intent which is simply the making sure the key value is set to the new values independent of if they were ever set previously.
There was a problem hiding this comment.
the method says "overridden", not "set", though. 😇
| } | ||
|
|
||
| private void given_this_is_removed_from(String key, Map<String, Object> props) { | ||
| props.remove(key); |
There was a problem hiding this comment.
wrap in assertTrue() for the reason detailed below? 😇
src/test/java/com/opencredo/connect/venafi/tpp/log/TppLogSourceConnectorTest.java
Outdated
Show resolved
Hide resolved
…eConfigTest.java Co-Authored-By: rufusfnash <[email protected]>
…eConfigTest.java Co-Authored-By: rufusfnash <[email protected]>
…to config_def_test_and_validate
Removing old comment
rufusfnash
dismissed
chbalzer’s stale review
I've made the changes in Intellij
chbalzer
reviewed
Jan 24, 2019
| @@ -43,7 +43,7 @@ public void start(Map<String, String> props) { | |||
| @Override | |||
| public List<Map<String, String>> taskConfigs(int maxTasks) { | |||
| if (maxTasks != 1) { | |||
| throw new IllegalArgumentException("max Tasks should be set to 1."); | |||
| log.info("Ignoring maxTasks as there can only be one."); | |||
There was a problem hiding this comment.
we dub thee the Highlander setting... 🤡
chbalzer
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.