Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[BUG] .company TLD marked as "invalid" as Destination-Url #103

Open
Kjarrigan opened this issue Oct 11, 2019 · 3 comments
Open

[BUG] .company TLD marked as "invalid" as Destination-Url #103

Kjarrigan opened this issue Oct 11, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Kjarrigan
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Alerting'
  2. Click on 'Destinations'
  3. Click on 'Add Destination'
  4. Select Type 'Custom Webhook'
  5. Enter Webhook URL - 'https://example.company'
  6. See error

Expected behavior
This is a valid URI

Screenshots
image

Additional context
Do you really need to check for a valid TLD? Something like .berlin shows an error as well.

@Kjarrigan
Copy link
Author

Just saw that there is a different repository for the "frontend" stuff. So probably this has to be moved to
opendistro-for-elasticsearch/alerting-kibana-plugin ?

@lucaswin-amzn
Copy link

Hi @Kjarrigan,

Yes you are correct this check is being done on the Kibana side. I will transfer your issue there.

As a work around you can try to create the destination through API, the backend validation is a little different. Let me know if you have any issues with this work around.

@lucaswin-amzn lucaswin-amzn transferred this issue from opendistro-for-elasticsearch/alerting Oct 14, 2019
@Kjarrigan
Copy link
Author

As a work around you can try to create the destination through API, the backend validation is a little different.

That worked thanks.

For anyone who has the same issue, the API-call is documented here

@ftianli-amzn ftianli-amzn added the bug Something isn't working label May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants