Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

URL validation for custom webhooks is incorrect #14

Closed
lucaswin-amzn opened this issue Apr 1, 2019 · 3 comments
Closed

URL validation for custom webhooks is incorrect #14

lucaswin-amzn opened this issue Apr 1, 2019 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lucaswin-amzn
Copy link

lucaswin-amzn commented Apr 1, 2019 •
edited by mihirsoni
Loading

The validation for custom webhooks located here:
https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/blob/master/public/pages/Destinations/components/createDestinations/CustomWebhook/validate.js#L18-L26

Does not allow specifying IPs and must be a valid DNS when in reality it could be different.
@mihirsoni mihirsoni added the good first issue Good for newcomers label Apr 1, 2019
@elfisher elfisher added the bug Something isn't working label Apr 10, 2019
@ricardobessadacosta
Copy link
Contributor

Hello @lucaswin-amzn , do you want to add support to accept URL with hostname, ipv4 and ipv6 in this function? I can change the regex to validate that if you like.

@mihirsoni
Copy link
Contributor

mihirsoni commented Jul 5, 2019 •
edited
Loading

@ricardobessa1 Sure. Feel free to create pull request.

@ricardobessadacosta ricardobessadacosta mentioned this issue Jul 7, 2019
Merged
@mihirsoni
Copy link
Contributor

Fixed by #67

@srilumpa srilumpa mentioned this issue Apr 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mihirsoni @elfisher @ricardobessadacosta @lucaswin-amzn