Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an org-wide PR template? #40

Open
3 tasks
kdmccormick opened this issue Nov 24, 2021 · 2 comments
Open
3 tasks

Create an org-wide PR template? #40

kdmccormick opened this issue Nov 24, 2021 · 2 comments

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Nov 24, 2021

As a result of openedx/open-edx-proposals#171, an initial pull request template was introduced to edx-platform.

Acceptance criteria:

  • Determine whether the PR template is being used consistently.
  • If so: Make it the default template across all Open edX repositories (using .github meta-repository?). Repositories should be able to opt-out of the template or use a custom one if they so choose.
  • If not: Choose to either (1) use linting to enforce the template, (2) find out why the template isn't being used and improve it, or (3) delete the template.
@sarina
Copy link
Contributor

sarina commented Feb 9, 2022

The way templated issues work is that a child repo will inherit all the issue templates from .github unless they define any of their own templates in a .github/ISSUE_TEMPLATE/ directory. I would think PR templates would be similarly overridable.

Anyway I very much support this effort! I get a bit frustrated sometimes when I encounter PRs without enough detail.

@kdmccormick kdmccormick transferred this issue from openedx/open-edx-proposals Dec 20, 2022
@kdmccormick kdmccormick changed the title **PR Template, Part 2** As a PR reviewer, I would like contributions across all repositories to consistently use a PR template. Create an org-wide PR template? Dec 20, 2022
@kdmccormick
Copy link
Member Author

Somewhat related: openedx/edx-cookiecutters#243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants