Elastic search search_after pagination #4473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza-56
force-pushed
the
hamza/PROD-4012
branch
from
950d3ae
to
970c92f
Compare
| @@ -1,4 +1,4 @@ | |||
| BASE_SEARCH_INDEX_FIELDS = ('aggregation_key', 'content_type', 'text') | |||
| BASE_SEARCH_INDEX_FIELDS = ('aggregation_key', 'aggregation_uuid', 'content_type', 'text', 'sort') | |||
There was a problem hiding this comment.
can this impact v1, considering this constant will be used there too?
There was a problem hiding this comment.
Yes, as a result of this change, the aggregation_uuid is now included in the response of /api/v1/search/all/.
| @@ -84,3 +84,32 @@ def _clone(self, klass=None, using=None, index=None, doc_type=None): | |||
| clone.aggs._params = {'aggs': self.aggs._params['aggs'].copy()} | |||
|
|
|||
| return clone | |||
|
|
|||
|
|
|||
| class SearchAfterSearch(FacetedSearch): | |||
There was a problem hiding this comment.
please add a docstring for the class
| @@ -99,6 +101,41 @@ class CustomPageNumberPagination(PageNumberPagination): | |||
| page_size_query_param = 'page_size' | |||
|
|
|||
|
|
|||
| class CustomSearchAfterPagination(PageNumberPagination): | |||
There was a problem hiding this comment.
nit: this can be renamed to SearchAfterPagination. Custom does not make sense in the beginning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing instructions:
GET /api/v1/search/all/
page_sizeparameter limits the number of results returned.search_afterparameter enables pagination by returning results that appear after a specified document.Example:
GET http://localhost:18381/api/v1/search/all/?page_size=1&search_after=[1728521062000,%22program:0b41be9d-10eb-4e10-ba2e-b2e47479e7b9%22]