Replace rest_framework_swagger with drf_yasg #176
Conversation
|
Thanks for the pull request, @NeOneSoft! I've created OSPR-6130 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
needs triage
open-source-contribution
|
@NeOneSoft Thank you for your contribution. Please let me know once this is ready for our review. |
openedx-webhooks
added
waiting on author
NeOneSoft
changed the title
NeOneSoft
force-pushed
the
ednx/edx-upgrade-swagger
branch
from
fecfcb0
to
833a2eb
Compare
|
@NeOneSoft Please resolve these conflicts. |
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 412 412
Branches 47 47
=========================================
Hits 412 412
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Hey there @awais786 !!.I already fix the conflicts. Could you please review this PR.?Thank you so much |
natabene
added
engineering review
and removed
waiting on author
|
I have verified its working. Please rebase.
|
|
@NeOneSoft The PR is ready to merge now. Could you rebase and resolve the conflicts once so I'll go ahead and merge this PR. |
NeOneSoft
force-pushed
the
ednx/edx-upgrade-swagger
branch
from
2992de1
to
1dd86b6
Compare
|
Hi @UsamaSadiq !! I already rebased, resolved the conflicts and squash the commits to clean up the PR, now is ready to check it if you are aggree. Thanks in advance !! |
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 12
Lines ? 412
Branches ? 64
==========================================
Hits ? 412
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Hi @NeOneSoft thanks for the effort. Seems like the quality failure will also need to be fixed before the PR can be merged. Could you have a look at the failures once you get opportunity. Thanks. |
feat: replace rest_framework_swagger with drf_yasg feat: resolve conflicted dependencies feat: resolve doc.txt file conflicted dependencies feat: resolve doc.txt file conflicted dependencies_02 feat: resolve doc.txt file conflicted dependencies_03 feat: resolve doc.txt file conflicted dependencies_04 feat: resolve conflicted files to master feat: resolve conflicted files to master branch feat: solve quality tests and conflicted files feat: solve conflicted files
NeOneSoft
force-pushed
the
ednx/edx-upgrade-swagger
branch
from
ee8c84c
to
6c9ee2d
Compare
|
@NeOneSoft Did you have a chance to implement the feedback? |
|
Hi@natabene, yes I already modified according the feedback but it seems that I'm having an import issue. I will check it and let you know once it's done. Thanks |
|
@NeOneSoft Just checking if you had a chance to look into this. |
|
Hi @natabene, sorry for my delay to answer. I will working on it tomorrow and let you know once is ready |
|
Addressed in #226 |
|
@NeOneSoft Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR was created following edx/upgrades#17 to switch django rest swagger to drf-yasg