-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge new Educators UX/UI in Open edX Docs #601
Conversation
Thanks for the pull request, @jswope00! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Added commit 205ba08 to delete empty placeholder files and index.rst files that are now unecessary with the new UX. Added benefit is by removing those index.rst files, Sphinx will now catch any errors where files are not included in the new educators navigation. |
This looks great! I'm clicking around and I like what I see. It does have some conflicts, so those need to be resolved. How would you like me to review this? I took a look at the diff and broadly it looks good - is there anything specific you'd like feedback on? I agree that removing the old index files is a good idea. |
******************************************************* | ||
|
||
.. toctree:: | ||
:maxdepth: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if having maxdepth 2 on these pages makes the pages a bit more unwieldly.
https://docsopenedxorg--601.org.readthedocs.build/en/601/educators/navigation/advanced_features.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also a little torn on that. Here is my argument for keeping it at 2:
- So far, we've broken these docs outs into their diataxis type but we still often have several how-to's in a single file (e.g. Enable a Survey, Add a Survey, Edit a Survey) when they go together, and so we don't have 1,000+ files. If we did TOC level 1, we'd show something like this:
OK, actually that's not bad. But I think it would involve renaming all the level 1 docs to make sure they action is clear (e.g. "Manage Survey Tool" instead of "Survey Tool"). This is something I'm open to do at the end of the project with leftover hours (I think there will be some).
- It makes the right sidebar navigation often redundant with the center panel. Especially for features where we only have one doc. e.g:
I say we bring this to the FC Group in our next meeting. But push this with 2 levels for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I agree with you. Leave at 2 levels for now, reasses after this merges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion otherwise looks good to me.
Change "Course Tags" to "Course Tags and Taxonomies" Co-authored-by: Sarina Canelake <[email protected]>
Where do you see conflicts? Mine shows "No conflicts, can be merged to main"? |
Hmm, maybe GH had a caching issue. Previously when I viewed the page, it said I couldn't merge due to conflicts. |
…swope00/educators_ux_ui
…0/docs.openedx.org into jswope00/educators_ux_ui
As part of FC-0067, this is the revised Educators Homepage with UX based on behavioral navigation. Screenshot: