-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: erase edx reference in the glossary #603
base: main
Are you sure you want to change the base?
fix: erase edx reference in the glossary #603
Conversation
This PR erase the edX reference in the glossary that belong to the developers section.
Thanks for the pull request, @Apgomeznext! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
I recently found a similar glossary in the educator's section from the documents John migrated. It is here: https://docs.openedx.org/en/latest/educators/references/glossary.html. |
@Apgomeznext which are you proposing to keep? |
@jswope00 - in this PR, references to |
I suggest keeping the glossary in the educators' section because it has a better UX design. In that case, we will need to erase this entrance. |
Sounds good to me |
So, I will close this PR. Should we erase this page now or wait to review the educators' glossary to create the redirection links? |
I think it's probably best to merge this, and put combining the glossaries into one as a separate task as it may be a big amount of work, especially if other dev docs reference this glossary. This looks good to me, but I would like John to take a look at my comment before merging. |
This PR erase the edX reference in the glossary that belong to the developers section.