feat: add activity and catalog tabs to budget detail page in LCM #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
+ Coverage 83.00% 83.20% +0.19%
==========================================
Files 415 422 +7
Lines 8944 9006 +62
Branches 1835 1841 +6
==========================================
+ Hits 7424 7493 +69
+ Misses 1479 1473 -6
+ Partials 41 40 -1
☔ View full report in Codecov by Sentry. |
adamstankiewicz
commented
Oct 3, 2023
Comment on lines
+7
to
+8
| <h3>Budget Name</h3> | ||
| <p>TODO</p> |
There was a problem hiding this comment.
[context] Placeholder behind feature flag for catalog tab entry point.
adamstankiewicz
commented
Oct 3, 2023
| @@ -0,0 +1,41 @@ | |||
| import { useEffect, useState } from 'react'; | |||
There was a problem hiding this comment.
[context] Unchanged. Just moved to standalone file from previous index.js file.
adamstankiewicz
requested review from
kiram15,
katrinan029,
jajjibhai008 and
a user
adamstankiewicz
force-pushed
the
ags/ent-7714
branch
from
b31b7eb
to
2fa50cf
Compare
kiram15
approved these changes
Oct 4, 2023
| )} | ||
| </> | ||
| ); | ||
| if (offerType === BUDGET_TYPES.ecommerce) { |
There was a problem hiding this comment.
Maybe a comment here explaining these two if statements and the different kinds of budgets (learner credit and offers) that we're rendering might make this a bit more readable?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ENT-7714
With feature flag DISABLED
With feature flag ENABLED
When visiting budget detail page route that doesn't exist
For all changes
Only if submitting a visual change