Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing gated top down allocation table subsidy service api usage #1087

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

alex-sheehan-edx
Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx commented Nov 7, 2023

https://2u-internal.atlassian.net/browse/ENT-7830

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ac1eb5c) 84.42% compared to head (ca9b664) 84.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
+ Coverage   84.42%   84.45%   +0.02%     
==========================================
  Files         470      470              
  Lines        9781     9801      +20     
  Branches     2025     2033       +8     
==========================================
+ Hits         8258     8277      +19     
- Misses       1481     1482       +1     
  Partials       42       42              
Files Coverage Δ
...rner-credit-management/BudgetDetailRedemptions.jsx 100.00% <100.00%> (ø)
.../learner-credit-management/data/tests/constants.js 100.00% <ø> (ø)
...components/learner-credit-management/data/utils.js 94.62% <100.00%> (+0.11%) ⬆️
src/data/services/EnterpriseSubsidyApiService.js 100.00% <100.00%> (ø)
...redit-management/data/hooks/useOfferRedemptions.js 89.83% <95.00%> (+0.46%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex-sheehan-edx alex-sheehan-edx force-pushed the asheehan-edx/ENT-7830 branch 2 times, most recently from 2b007ed to 8c525e4 Compare November 7, 2023 22:46
@alex-sheehan-edx alex-sheehan-edx marked this pull request as ready for review November 7, 2023 22:49
@alex-sheehan-edx alex-sheehan-edx force-pushed the asheehan-edx/ENT-7830 branch 7 times, most recently from ee201d0 to c484327 Compare November 8, 2023 22:45
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alex-sheehan-edx alex-sheehan-edx force-pushed the asheehan-edx/ENT-7830 branch 2 times, most recently from dcfe52a to 70e50ae Compare November 9, 2023 00:01
@alex-sheehan-edx alex-sheehan-edx merged commit f55a448 into master Nov 9, 2023
6 checks passed
@alex-sheehan-edx alex-sheehan-edx deleted the asheehan-edx/ENT-7830 branch November 9, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants