Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve some issue on analytics v2 #1346

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Nov 12, 2024

Description

  • Analytics Tabs were not evenly spaced on analytics V2. So fix that issue.
  • The last updated date format did not match with original analytics last updated format for fix that issue.
  • Download CSV button styles and alignment did not match with original analytics. So fix that issue.

image
image
image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (ba8fc56) to head (149f4e1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1346   +/-   ##
=======================================
  Coverage   85.55%   85.56%           
=======================================
  Files         600      600           
  Lines       13212    13215    +3     
  Branches     2785     2777    -8     
=======================================
+ Hits        11304    11307    +3     
  Misses       1842     1842           
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 changed the title fix: tabs spacing issue analytics v2 fix: resolve some issue on analytics v2 Nov 13, 2024
@jajjibhai008 jajjibhai008 merged commit dd5c77d into master Nov 13, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9705-2 branch November 13, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants