Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pagination for reporting configurations #1357

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Nov 20, 2024

Description
These changes are to resolve the issue that NUS is facing. Only 10 reports are showing up on the admin portal. This is a temporary solution, I am working on implementing pagination on the Reporting Configuration page.

Issue: https://2u-internal.atlassian.net/browse/ENT-9728

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (927f8c0) to head (7d6cf54).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
+ Coverage   85.78%   85.80%   +0.01%     
==========================================
  Files         600      600              
  Lines       13222    13222              
  Branches     2787     2746      -41     
==========================================
+ Hits        11343    11345       +2     
+ Misses       1814     1812       -2     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 merged commit 349cae2 into master Dec 3, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9768 branch December 3, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants