chore: update max allowed highlights per set and max number of highlight sets #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
LGTM. I assume openedx/enterprise-catalog#672 will be merged/released first?
| @@ -43,10 +43,10 @@ export const TAB_TITLES = { | |||
| export const MAX_HIGHLIGHT_TITLE_LENGTH = 60; | |||
|
|
|||
| // Max highlight sets per enteprise curation | |||
There was a problem hiding this comment.
nit: while we're in here, typo in enteprise above ;)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 412 412
Lines 8849 8849
Branches 1820 1820
=======================================
Hits 7346 7346
Misses 1464 1464
Partials 39 39
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs with: openedx/enterprise-catalog#672