Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: creates a modal to add members #1363

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Dec 4, 2024

Description

Creates a modal to add members to an existing group
https://2u-internal.atlassian.net/browse/ENT-9602

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review December 10, 2024 16:42
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 57.69231% with 66 lines in your changes missing coverage. Please review.

Project coverage is 85.37%. Comparing base (371f043) to head (368dfe2).

Files with missing lines Patch % Lines
...onents/PeopleManagement/AddMembersModalContent.jsx 5.26% 36 Missing ⚠️
...rc/components/PeopleManagement/AddMembersModal.jsx 55.26% 17 Missing ⚠️
...ement/data/hooks/useEnterpriseLearnersTableData.js 0.00% 5 Missing ⚠️
src/data/services/LmsApiService.js 20.00% 4 Missing ⚠️
...mponents/PeopleManagement/AddMembersBulkAction.jsx 84.61% 2 Missing ⚠️
...nents/PeopleManagement/RemoveMembersBulkAction.jsx 88.88% 1 Missing ⚠️
...gement/data/hooks/useAllEnterpriseGroupLearners.js 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
- Coverage   85.72%   85.37%   -0.35%     
==========================================
  Files         609      617       +8     
  Lines       13363    13474     +111     
  Branches     2812     2780      -32     
==========================================
+ Hits        11455    11504      +49     
- Misses       1838     1900      +62     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant