-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustments to tile responsiveness when sidebar is opened #1221
Comments
@jmakowski1123 It only affects smaller displays. I think we can address that by switching to three cards per row instead of four? (for small displays) |
Rather than setting a fixed number of columns at specific breakpoints and letting the preview text flow across an arbitrary number of lines, I think we should use different fixed constraints (Figma link with examples and comments):
Rather than a fixed number of columns between each breakpoint, this approach limits the card size to ensure all cards are a reasonable size in all dimensions, and allows them to use up more space when it's available. I've left the constraints a bit open-ended here. I'm wondering about feasibility of this sort of approach— let me know if more specific constraints, examples and breakpoints would be helpful. Does something more like this responsive approach seem possible? |
@sdaitzman Yes, we can do that and I agree it's better than dealing with breakpoints and fixed columns and all that. |
Ack! I will check that tomorrow and post an update here. |
As the other PR was merged, I will create a small task for this next sprint. |
Discussed this at libraries relaunch touchpoint today. We decided to (pending evaluating feasibility of scoping these changes to the content libraries studio page only):
|
^ Ideally, we'd add a way that we can enable this "full width mode" for just this one page, and potentially other course authoring MFE pages in the future. If it's too complicated to do, or would affect ALL pages and potentially introduce layout issues on other pages, we can consider postponing it. |
We can parametrize the header only for the library authoring, so I think it is possible to make the change only for this context. Let me know if I should include the header/content size change as part of this issue. CC @bradenmacdonald |
@rpenido Yes please include it with this issue. Thanks. |
@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox. |
This looks ok to my non-UI eyes |
Currently when the sidebar is opened, tiles with long titles and descriptions become very elongated. UI solution?
The text was updated successfully, but these errors were encountered: