[BD-46] feat: added CSS custom media query support #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
the
blended
|
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
This was referenced Feb 19, 2023
Closed
config/webpack.dev.config.js
Outdated
| @@ -9,6 +9,7 @@ const HtmlWebpackPlugin = require('html-webpack-plugin'); | |||
| const path = require('path'); | |||
| const PostCssAutoprefixerPlugin = require('autoprefixer'); | |||
| const PostCssRTLCSS = require('postcss-rtlcss'); | |||
| const CustomMediaCSS = require('postcss-custom-media'); | |||
There was a problem hiding this comment.
nit: might recommend including PostCss as a prefix to be consistent with these other PostCSS plugin imports above.
config/webpack.dev.config.js
Outdated
| @@ -85,6 +86,7 @@ module.exports = merge(commonConfig, { | |||
| plugins: [ | |||
| PostCssAutoprefixerPlugin(), | |||
| PostCssRTLCSS(), | |||
| CustomMediaCSS(), | |||
There was a problem hiding this comment.
We'll need to also make similar changes to the other Webpack configs as well, i.e.:
webpack.dev-stage.config.jswebpack.prod.config.js
There was a problem hiding this comment.
Done, thanks
Closed
4 tasks
adamstankiewicz
approved these changes
Feb 24, 2023
|
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
🎉 This PR is included in version 12.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@custom-mediafrom design tokens with style-dictionary.postcss-custom-mediato @edx/frontend-build's default Webpack configs for all MFEs.Issue: openedx/paragon#2015