Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve #360 make style consistent across outlines #361

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

ghassanmas
Copy link
Member

This changes make the style consistent across the first three
headline line levels

  1. The first level add CSS prop initial
  2. The second level change prop from capital to inital as describted in Text in headline 2 will always show in capital letter #360
  3. No change

 This changes make the style consistent across the first three
 headline line levels

 1. The first level add CSS prop initial
 2. The second level change prop from capital to inital
 3. No change
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 11, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 11, 2023

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f942ef9) 90.38% compared to head (2bc447f) 90.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files         221      221           
  Lines        3899     3899           
  Branches      757      757           
=======================================
  Hits         3524     3524           
  Misses        356      356           
  Partials       19       19           
Impacted Files Coverage Δ
src/editors/data/constants/tinyMCEStyles.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! Would someone be able to review/merge this for us? Thanks!

@mphilbrick211 mphilbrick211 requested a review from a team July 11, 2023 14:26
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 17, 2023
@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! Just following up on this!

@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! Just following up on this!

Hi @openedx/teaching-and-learning - would someone be able to help with this?

@mphilbrick211
Copy link

Hi @connorhaugh! Thanks so much for helping with review. Are you able to merge as well?

@mphilbrick211 mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 10, 2023
@jristau1984 jristau1984 merged commit a76c93c into openedx:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants