Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typeahead sort and styling #396

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

KristinAoki
Copy link
Member

The styles added to the video upload page was forcing all the form controls to be a fixed size and their trailing elements to render outside of the form control. Now the added styling only applies to the video upload page, as was originally intended. This PR also changes the sort method for the typeahead dropdown. The previous sort method was an in-place sorter so half of the time it would throw an error and not render the list of options.

Testing

  1. Navigate to the studio home page.
  2. Click "New course".
  3. All input boxes should span the width of the main body.
  4. Click the expand option for in the organization input.
  5. Should render list of options with no errors.
  6. Begin typing in the input
  7. Should update rendered list with no errors

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (eb320ab) 90.52% compared to head (86b50e1) 90.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   90.52%   90.53%           
=======================================
  Files         230      230           
  Lines        4139     4140    +1     
  Branches      839      839           
=======================================
+ Hits         3747     3748    +1     
  Misses        371      371           
  Partials       21       21           
Files Coverage Δ
...ors/containers/VideoUploadEditor/VideoUploader.jsx 94.73% <ø> (ø)
...itors/sharedComponents/TypeaheadDropdown/index.jsx 88.37% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit a0089eb into main Sep 27, 2023
6 checks passed
@jesperhodge jesperhodge mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants