-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show advanced settings button color #417
fix: Show advanced settings button color #417
Conversation
Thanks for the pull request, @Lunyachek! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@Lunyachek I invited you to the openedx-triage team on GitHub which will allow tests to run without approval, can you look for the invite in your email? It looks like there's a CI failure here though. |
Flagging this for you, @Lunyachek! |
Hi @Lunyachek - friendly follow-up on this. |
Hi @Lunyachek! Just checking in on this. |
@mphilbrick211 Sorry, it's my fault. I missed the updates on this pull request. Can it be reopened, or should I create a new pull request? |
Here you go, @Lunyachek! |
Hi @Lunyachek - are you still planning to pursue this PR? |
Hi! Thank you for your contribution to this repo. This repo is being deprecated and all the code is being moved to |
As mentioned above, we've now moved this code into https://github.com/openedx/frontend-app-course-authoring/ so we'll need you to please re-open this PR against |
@Lunyachek Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Cosmetic adjustment: We removed the 'text-info-500' class that was conflicting with the styles of the 'Show advanced settings' button, preventing us from applying a different color to it. We believe that the 'text-info-500' class is unnecessary for this button. Even without this class, the button will appear correctly, and you'll still have the ability to change its color in branded themes.
Without a specific theme, we don't have a difference with or without this class
But with branded theme this fix will help us to override blue color with custom brand color