Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use plugins repo, and enable accessibility checker and powerpaste #420

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

kenclary
Copy link
Contributor

feat: use plugins repo, and enable accessibility checker and powerpaste

@kenclary kenclary force-pushed the kenclary/plugins branch 2 times, most recently from 85de7ab to 94d00a7 Compare November 21, 2023 18:36
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3aa9088) 90.49% compared to head (5342f16) 90.49%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         228      228           
  Lines        4115     4115           
  Branches      822      822           
=======================================
  Hits         3724     3724           
  Misses        370      370           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consolidate the test statements in setuptest.js.

Also screenshots showing this works would improve my confidence in this pr.

What was the major direction change that led here?

@kenclary
Copy link
Contributor Author

What was the major direction change that led here?

From a slack thread discussion: "I suspect this means that you can basically override the version of any dependency you would like, no matter how deep it is in the resolved package-lock.json"

Essentially, instead of importing the plugins repo(s) directly in the MFE, and trying to pass the configuration down into the FLCC component(s), just doing it directly in FLCC. In theory, the NPM aliasing (to be) set up for the MFEs will recurse down the dependencies.

Copy link
Member

@KristinAoki KristinAoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to work. However when I add

 { moduleName: 'frontend-components-tinymce-advanced-plugins', dir: '../frontend-components-tinymce-advanced-plugins-edx' },

to my module.config,js file in course-authoring, missing import errors occur for the plugins. I think this is an issue the frontend-components-tinymce-advanced-plugins-edx because it throws an error when I try to run npm run build. This will be confirmed when used on stage.

@kenclary
Copy link
Contributor Author

I think this is an issue the frontend-components-tinymce-advanced-plugins-edx because it throws an error when I try to run npm run build.

What error do you get? It builds fine on tag/release, and builds fine locally for me.

@KristinAoki
Copy link
Member

I think this is an issue the frontend-components-tinymce-advanced-plugins-edx because it throws an error when I try to run npm run build.

What error do you get? It builds fine on tag/release, and builds fine locally for me.

When I run npm run build in frontend-components-tinymce-advanced-plugins-edx it says that it is unable to build. The errors for when I put it in the module.config.js it says that unable to find the export form tinymce/plugins/{plugin_name). But this only occurs when I am using the module.config.js override, so this is referencing my local version of frontend-components-tinymce-advanced-plugins-edx. I think everything should be fine when referencing the tag/release.

@kenclary
Copy link
Contributor Author

I think this is an issue the frontend-components-tinymce-advanced-plugins-edx because it throws an error when I try to run npm run build.

What error do you get? It builds fine on tag/release, and builds fine locally for me.

When I run npm run build in frontend-components-tinymce-advanced-plugins-edx it says that it is unable to build. The errors for when I put it in the module.config.js it says that unable to find the export form tinymce/plugins/{plugin_name). But this only occurs when I am using the module.config.js override, so this is referencing my local version of frontend-components-tinymce-advanced-plugins-edx. I think everything should be fine when referencing the tag/release.

OK. I suspect you could fix your local build by pulling the latest code from main (and maybe deleting node_modules/ and running npm i and such).

In the meantime, I'll go ahead and merge this so it can make it into the MFEs.

@kenclary kenclary merged commit c0bc54a into main Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants