-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use plugins repo, and enable accessibility checker and powerpaste #420
Conversation
85de7ab
to
94d00a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
=======================================
Coverage 90.49% 90.49%
=======================================
Files 228 228
Lines 4115 4115
Branches 822 822
=======================================
Hits 3724 3724
Misses 370 370
Partials 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consolidate the test statements in setuptest.js.
Also screenshots showing this works would improve my confidence in this pr.
What was the major direction change that led here?
...itors/containers/ProblemEditor/components/EditProblemView/AnswerWidget/AnswerOption.test.jsx
Outdated
Show resolved
Hide resolved
From a slack thread discussion: "I suspect this means that you can basically override the version of any dependency you would like, no matter how deep it is in the resolved package-lock.json" Essentially, instead of importing the plugins repo(s) directly in the MFE, and trying to pass the configuration down into the FLCC component(s), just doing it directly in FLCC. In theory, the NPM aliasing (to be) set up for the MFEs will recurse down the dependencies. |
94d00a7
to
1fba93a
Compare
1fba93a
to
5342f16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything appears to work. However when I add
{ moduleName: 'frontend-components-tinymce-advanced-plugins', dir: '../frontend-components-tinymce-advanced-plugins-edx' },
to my module.config,js
file in course-authoring
, missing import errors occur for the plugins. I think this is an issue the frontend-components-tinymce-advanced-plugins-edx
because it throws an error when I try to run npm run build
. This will be confirmed when used on stage.
What error do you get? It builds fine on tag/release, and builds fine locally for me. |
When I run |
OK. I suspect you could fix your local build by pulling the latest code from main (and maybe deleting In the meantime, I'll go ahead and merge this so it can make it into the MFEs. |
feat: use plugins repo, and enable accessibility checker and powerpaste