Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misssing part of paid plugin configuration #428

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

kenclary
Copy link
Contributor

@kenclary kenclary commented Dec 8, 2023

fix: misssing part of paid plugin configuration

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2aeb094) 90.51% compared to head (b0ca07d) 90.55%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/editors/containers/VideoUploadEditor/index.jsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   90.51%   90.55%   +0.04%     
==========================================
  Files         227      227              
  Lines        4111     4120       +9     
  Branches      826      831       +5     
==========================================
+ Hits         3721     3731      +10     
  Misses        369      369              
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@KristinAoki KristinAoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes not pertaining to changed file

  1. To have the correct styling for the accessibility checker, you will need to add the styles in hooks.js to the content styles
import {a11ycheckerCss} from 'frontend-components-tinymce-advanced-plugins'
...
content_style: tinyMCEStyles + a11ycheckerCss,
  1. remove a11yCheckerCss from list of plugins in src/editors/data/constants/tinyMCE.js
  2. use the plugin changes from draft PR feat: update tinymce plugin #429

@kenclary kenclary force-pushed the kenclary/plugins branch 2 times, most recently from 745ad90 to f1c661f Compare December 8, 2023 20:39
@kenclary kenclary merged commit 1137c88 into main Dec 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants