Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: answer range format validation and error message in Numerical input #511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ihor-romaniuk
Copy link
Contributor

Pull Requests to frontend-app-authoring: openedx/frontend-app-authoring#1557

Description

These fixes validate input range format; it accepts the following response forms: [1,10], [1, 10], [ 1,10 ], [ 1, 10 ], [1, 10 ] , [ 1, 10], [1.1,10], [1.1,10.1], [1.1,10.1] and display error on incorrect format like: [1.10], [1;10], [1/10], etc.

Steps to reproduce

  1. Go to studio -> unit -> problem -> Numerical input
  2. In answers click on Add answer button -> Add answer range
  3. Fill in value [5.8), click Save (like user set dot instead of comma by mistake)

Actual result

Nothing happened, in console there's error
000
Note: the same when user print additional bracket

Expected result

Some validation should be for field or some error message for user should be shown
Before save:
0001
After save:
0002

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 9, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (bc25bb4) to head (1f783aa).

Files with missing lines Patch % Lines
...ntainers/ProblemEditor/data/ReactStateOLXParser.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   88.99%   88.99%   -0.01%     
==========================================
  Files         248      248              
  Lines        4561     4570       +9     
  Branches      943      951       +8     
==========================================
+ Hits         4059     4067       +8     
- Misses        470      471       +1     
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

@openedx/2u-tnl this is ready for review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants