Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edx-platform django-mptt python 3.8 compatibility #6396

Closed
wants to merge 3 commits into from
Closed

fix: edx-platform django-mptt python 3.8 compatibility #6396

wants to merge 3 commits into from

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Jun 13, 2024 •
edited
Loading

Bump to python 3.9, which later needs another bump to 3.11

TODO

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 13, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 13, 2024 •
edited
Loading

Thanks for the pull request, @OmarIthawi!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @committers-translations. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-actions GitHub Actions
Copy link

✅ All translation files are valid.

This comment has been posted by the validate-translation-files.yml GitHub Actions workflow.

@OmarIthawi
fix: edx-platform django-mptt python 3.8 compatibility
c39caeb 
- Bump to python 3.9, which later needs another bump to 3.11
- Remove the IS_OPENEDX_TRANSLATIONS_WORKFLOW envirnoment variable as
  it's n longer needed
@mphilbrick211
Copy link

Hi @OmarIthawi! Is this still in progress?

@OmarIthawi
Copy link
Member Author

Still in progress. I'll mark as draft.

@OmarIthawi OmarIthawi marked this pull request as draft August 24, 2024 14:27
@OmarIthawi OmarIthawi mentioned this pull request Aug 29, 2024
Closed
@OmarIthawi
Copy link
Member Author

closing in favor of #7152

@OmarIthawi OmarIthawi closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OmarIthawi @openedx-webhooks @mphilbrick211