-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove frontend-lib-content-components from workflow [FC-0062] #7070
chore: remove frontend-lib-content-components from workflow [FC-0062] #7070
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bradenmacdonald! Always a pleasure to review your PRs :)
Please also remove
openedx-translations/transifex.yml
Lines 256 to 262 in d654700
# frontend-lib-content-components | |
- filter_type: file | |
file_format: KEYVALUEJSON | |
source_language: en | |
source_file: translations/frontend-lib-content-components/src/i18n/transifex_input.json | |
translation_files_expression: 'translations/frontend-lib-content-components/src/i18n/messages/<lang>.json' | |
Alsp remove to the actual resource translations (sorry for chaning my mind mid-way). Removing the actual resources won't break the Makefile
scripting because it just ignores empty or missing files.
However, there's a ton of references for the frontend-lib-content-components
that should be taken care of including a questionalbe reference in the communications app.
I hope you're aware of the rabbit hole. Nevertheless, thank you for taking the time to refactor.
6f077ee
to
7ebde24
Compare
@OmarIthawi Thanks - done!
I'm not sure what you'd like me to do for this, sorry. Is that something to do in Transifex itself? If so I'm not sure if I even have permission.
Good point. I will open some more PRs to update those various references. |
Appologies. Please remove this directory from the repository: All of it, including both source strings and the translations. |
Ah, gotcha. Done. Thanks for all the help, @OmarIthawi :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @bradenmacdonald!
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
We've moved frontend-lib-content-components into frontend-app-course-authoring, so we don't need to extract translations from content-components any more.
Related PR: openedx/frontend-app-authoring#1208