Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: finished FontAwesome deprecation #2327

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented May 24, 2023

Description

Issue: #2235

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label May 24, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (c13dfb1) 90.98% compared to head (a227b5a) 91.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #2327      +/-   ##
==========================================
+ Coverage   90.98%   91.02%   +0.04%     
==========================================
  Files         214      214              
  Lines        3537     3534       -3     
  Branches      862      860       -2     
==========================================
- Hits         3218     3217       -1     
+ Misses        311      309       -2     
  Partials        8        8              
Impacted Files Coverage Δ
src/IconButton/index.jsx 93.75% <100.00%> (+9.53%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viktorrusakov viktorrusakov linked an issue May 26, 2023 that may be closed by this pull request
@viktorrusakov viktorrusakov merged commit 9a94ac5 into openedx:alpha May 26, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

monteri pushed a commit to raccoongang/paragon that referenced this pull request Aug 17, 2023
* feat: finished FontAwesome deprecation

* refactor: deleted fonawesom packages

* refactor: after review
PKulkoRaccoonGang added a commit to raccoongang/paragon that referenced this pull request Aug 18, 2023
* feat: finished FontAwesome deprecation

* refactor: deleted fonawesom packages

* refactor: after review
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

PKulkoRaccoonGang added a commit that referenced this pull request Aug 1, 2024
* feat: finished FontAwesome deprecation

* refactor: deleted fonawesom packages

* refactor: after review
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
* feat: finished FontAwesome deprecation

* refactor: deleted fonawesom packages

* refactor: after review
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
* feat: finished FontAwesome deprecation

* refactor: deleted fonawesom packages

* refactor: after review
PKulkoRaccoonGang added a commit that referenced this pull request Aug 5, 2024
* feat: finished FontAwesome deprecation

* refactor: deleted fonawesom packages

* refactor: after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Finish FontAwesome deprecation
5 participants