Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dropzone className prop #2950

Merged

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Dec 18, 2023

Description

Minor fix related to the className props of the Dropzone component.

When passed className="some-class", the current implementation adds a property { className: 'some-class', ...} to the object passed in the classNames function.

This results in the rendered object having the literal className as a CSS class, not the actual some-class.

image

More info

Closes:

Deploy Preview

N/A

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 18, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 18, 2023

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5336cf0
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6581f24cd172fc0008bdb68b
😎 Deploy Preview https://deploy-preview-2950--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rpenido rpenido marked this pull request as ready for review December 19, 2023 14:54
Copy link
Contributor

@viktorrusakov viktorrusakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nice catch @rpenido, thanks for fixing this 🙂. Could you also please rebase on master? We pushed a commit there earlier today that would fix your failing tests pipeline, then I will be able to merge this.

@viktorrusakov viktorrusakov linked an issue Dec 19, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5c0510) 92.83% compared to head (5336cf0) 92.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2950   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         235      235           
  Lines        4245     4245           
  Branches     1032     1032           
=======================================
  Hits         3941     3941           
  Misses        300      300           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov viktorrusakov merged commit 28aada9 into openedx:master Dec 19, 2023
10 checks passed
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@rpenido rpenido deleted the rpenido/fix-dropzone-classname-props branch December 19, 2023 19:55
@openedx-semantic-release-bot

🎉 This PR is included in version 21.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 22.0.0-alpha.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

BUG: Dropzone doesn't apply className prop
4 participants