-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dropzone className prop #2950
fix: Dropzone className prop #2950
Conversation
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nice catch @rpenido, thanks for fixing this 🙂. Could you also please rebase on master
? We pushed a commit there earlier today that would fix your failing tests pipeline, then I will be able to merge this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2950 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 235 235
Lines 4245 4245
Branches 1032 1032
=======================================
Hits 3941 3941
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Minor fix related to the
className
props of theDropzone
component.When passed
className="some-class"
, the current implementation adds a property{ className: 'some-class', ...}
to the object passed in theclassNames
function.This results in the rendered object having the literal
className
as a CSS class, not the actualsome-class
.More info
Closes:
Deploy Preview
N/A
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist