Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] Remove SCSS variable usages in components and other custom styles #2137

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Mar 15, 2023

Description

  • Ensure the component-specific CSS variables can still display on the docs site under the "Variables" section.
  • May need to generate component-specific stylesheets and aggregate them into one.
  • Remove SCSS variables in favor of strictly using CSS variables throughout Paragon codebase (i.e., no more SCSS variables defined with CSS variables as their values).
  • Ensure the SCSS variables displayed on component pages in the documentation website show the equivalent CSS variables definitions instead.
  • Consider other impacts to these proposed changes.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Mar 15, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] DRAFTPeter kulko/remove scss variable usages in components [BD-46] DRAFT: Remove SCSS variable usages in components and other custom styles Mar 15, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Mar 15, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/remove-SCSS-variable-usages-in-components branch 2 times, most recently from dccd211 to 56ccf7b Compare March 15, 2023 12:01
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (100ee5c) 91.06% compared to head (fc7aab5) 91.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #2137   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files         214      214           
  Lines        3524     3524           
  Branches      853      853           
=======================================
  Hits         3209     3209           
  Misses        307      307           
  Partials        8        8           
Impacted Files Coverage Δ
...wScroll/data/useOverflowScrollElementAttributes.js 97.72% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/remove-SCSS-variable-usages-in-components branch from 52a854e to 5047353 Compare March 15, 2023 13:48
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/remove-SCSS-variable-usages-in-components branch 3 times, most recently from 13e504b to f5cf33a Compare March 19, 2023 13:08
@viktorrusakov viktorrusakov force-pushed the Peter_Kulko/remove-SCSS-variable-usages-in-components branch from ca89222 to daab3ad Compare April 14, 2023 06:28
@viktorrusakov viktorrusakov force-pushed the Peter_Kulko/remove-SCSS-variable-usages-in-components branch from daab3ad to 4f01a2e Compare April 28, 2023 08:46
@viktorrusakov viktorrusakov changed the title [BD-46] DRAFT: Remove SCSS variable usages in components and other custom styles [BD-46] Remove SCSS variable usages in components and other custom styles Apr 28, 2023
@viktorrusakov viktorrusakov force-pushed the Peter_Kulko/remove-SCSS-variable-usages-in-components branch from 4f01a2e to fc7aab5 Compare April 28, 2023 09:36
@viktorrusakov viktorrusakov merged commit 27af4e3 into openedx:alpha May 5, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

monteri pushed a commit to raccoongang/paragon that referenced this pull request Aug 17, 2023
* feat: removed SCSS variable usages in components and other custom styles

* feat: removed SCSS variable files in components

* refactor: code refactoring

* refactor: deleted old logic to search SCSS variables

* refactor: refactoring variables and Anotation component

* feat: added CSS hooks plus tokens for IconButton

* refactor: refacoring IconButton component

* refactor: some refactoring

* feat: update replace-scss-vars script to handle interpolation expressions

* feat: remove SCSS variables in docs site and start using custom media queries

---------

Co-authored-by: Viktor Rusakov <[email protected]>
PKulkoRaccoonGang added a commit to raccoongang/paragon that referenced this pull request Aug 18, 2023
* feat: removed SCSS variable usages in components and other custom styles

* feat: removed SCSS variable files in components

* refactor: code refactoring

* refactor: deleted old logic to search SCSS variables

* refactor: refactoring variables and Anotation component

* feat: added CSS hooks plus tokens for IconButton

* refactor: refacoring IconButton component

* refactor: some refactoring

* feat: update replace-scss-vars script to handle interpolation expressions

* feat: remove SCSS variables in docs site and start using custom media queries

---------

Co-authored-by: Viktor Rusakov <[email protected]>
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

PKulkoRaccoonGang added a commit that referenced this pull request Aug 1, 2024
* feat: removed SCSS variable usages in components and other custom styles

* feat: removed SCSS variable files in components

* refactor: code refactoring

* refactor: deleted old logic to search SCSS variables

* refactor: refactoring variables and Anotation component

* feat: added CSS hooks plus tokens for IconButton

* refactor: refacoring IconButton component

* refactor: some refactoring

* feat: update replace-scss-vars script to handle interpolation expressions

* feat: remove SCSS variables in docs site and start using custom media queries

---------

Co-authored-by: Viktor Rusakov <[email protected]>
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
* feat: removed SCSS variable usages in components and other custom styles

* feat: removed SCSS variable files in components

* refactor: code refactoring

* refactor: deleted old logic to search SCSS variables

* refactor: refactoring variables and Anotation component

* feat: added CSS hooks plus tokens for IconButton

* refactor: refacoring IconButton component

* refactor: some refactoring

* feat: update replace-scss-vars script to handle interpolation expressions

* feat: remove SCSS variables in docs site and start using custom media queries

---------

Co-authored-by: Viktor Rusakov <[email protected]>
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
* feat: removed SCSS variable usages in components and other custom styles

* feat: removed SCSS variable files in components

* refactor: code refactoring

* refactor: deleted old logic to search SCSS variables

* refactor: refactoring variables and Anotation component

* feat: added CSS hooks plus tokens for IconButton

* refactor: refacoring IconButton component

* refactor: some refactoring

* feat: update replace-scss-vars script to handle interpolation expressions

* feat: remove SCSS variables in docs site and start using custom media queries

---------

Co-authored-by: Viktor Rusakov <[email protected]>
PKulkoRaccoonGang added a commit that referenced this pull request Aug 5, 2024
* feat: removed SCSS variable usages in components and other custom styles

* feat: removed SCSS variable files in components

* refactor: code refactoring

* refactor: deleted old logic to search SCSS variables

* refactor: refactoring variables and Anotation component

* feat: added CSS hooks plus tokens for IconButton

* refactor: refacoring IconButton component

* refactor: some refactoring

* feat: update replace-scss-vars script to handle interpolation expressions

* feat: remove SCSS variables in docs site and start using custom media queries

---------

Co-authored-by: Viktor Rusakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[discovery] Remove SCSS variable usages in components and other custom styles
5 participants