-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] Remove SCSS variable usages in components and other custom styles #2137
[BD-46] Remove SCSS variable usages in components and other custom styles #2137
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
dccd211
to
56ccf7b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## alpha #2137 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 214 214
Lines 3524 3524
Branches 853 853
=======================================
Hits 3209 3209
Misses 307 307
Partials 8 8
☔ View full report in Codecov by Sentry. |
52a854e
to
5047353
Compare
13e504b
to
f5cf33a
Compare
ca89222
to
daab3ad
Compare
daab3ad
to
4f01a2e
Compare
4f01a2e
to
fc7aab5
Compare
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.0.0-alpha.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat: removed SCSS variable usages in components and other custom styles * feat: removed SCSS variable files in components * refactor: code refactoring * refactor: deleted old logic to search SCSS variables * refactor: refactoring variables and Anotation component * feat: added CSS hooks plus tokens for IconButton * refactor: refacoring IconButton component * refactor: some refactoring * feat: update replace-scss-vars script to handle interpolation expressions * feat: remove SCSS variables in docs site and start using custom media queries --------- Co-authored-by: Viktor Rusakov <[email protected]>
* feat: removed SCSS variable usages in components and other custom styles * feat: removed SCSS variable files in components * refactor: code refactoring * refactor: deleted old logic to search SCSS variables * refactor: refactoring variables and Anotation component * feat: added CSS hooks plus tokens for IconButton * refactor: refacoring IconButton component * refactor: some refactoring * feat: update replace-scss-vars script to handle interpolation expressions * feat: remove SCSS variables in docs site and start using custom media queries --------- Co-authored-by: Viktor Rusakov <[email protected]>
🎉 This PR is included in version 22.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat: removed SCSS variable usages in components and other custom styles * feat: removed SCSS variable files in components * refactor: code refactoring * refactor: deleted old logic to search SCSS variables * refactor: refactoring variables and Anotation component * feat: added CSS hooks plus tokens for IconButton * refactor: refacoring IconButton component * refactor: some refactoring * feat: update replace-scss-vars script to handle interpolation expressions * feat: remove SCSS variables in docs site and start using custom media queries --------- Co-authored-by: Viktor Rusakov <[email protected]>
* feat: removed SCSS variable usages in components and other custom styles * feat: removed SCSS variable files in components * refactor: code refactoring * refactor: deleted old logic to search SCSS variables * refactor: refactoring variables and Anotation component * feat: added CSS hooks plus tokens for IconButton * refactor: refacoring IconButton component * refactor: some refactoring * feat: update replace-scss-vars script to handle interpolation expressions * feat: remove SCSS variables in docs site and start using custom media queries --------- Co-authored-by: Viktor Rusakov <[email protected]>
* feat: removed SCSS variable usages in components and other custom styles * feat: removed SCSS variable files in components * refactor: code refactoring * refactor: deleted old logic to search SCSS variables * refactor: refactoring variables and Anotation component * feat: added CSS hooks plus tokens for IconButton * refactor: refacoring IconButton component * refactor: some refactoring * feat: update replace-scss-vars script to handle interpolation expressions * feat: remove SCSS variables in docs site and start using custom media queries --------- Co-authored-by: Viktor Rusakov <[email protected]>
* feat: removed SCSS variable usages in components and other custom styles * feat: removed SCSS variable files in components * refactor: code refactoring * refactor: deleted old logic to search SCSS variables * refactor: refactoring variables and Anotation component * feat: added CSS hooks plus tokens for IconButton * refactor: refacoring IconButton component * refactor: some refactoring * feat: update replace-scss-vars script to handle interpolation expressions * feat: remove SCSS variables in docs site and start using custom media queries --------- Co-authored-by: Viktor Rusakov <[email protected]>
Description
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist