Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract additional dashboard strings for translation #840

Closed
bmtcril opened this issue May 29, 2024 · 3 comments · Fixed by #842
Closed

Extract additional dashboard strings for translation #840

bmtcril opened this issue May 29, 2024 · 3 comments · Fixed by #842
Assignees
Labels
backport PR backports a change from main to a named release. bug Report of or fix for something that isn't working as intended

Comments

@bmtcril
Copy link
Contributor

bmtcril commented May 29, 2024

Currently we are missing some strings from Dashboard translations:

  • chart.meta.sliceNameOverride

We should be able to test this by running make extract_translations to debug and make sure the strings get picked up correctly.

@Ian2012
Copy link
Contributor

Ian2012 commented May 29, 2024

I don't think "position.*.meta.code" would work as that's not rendered. We should add that to other yaml and load it like we do for dataset_strings

@bmtcril bmtcril added bug Report of or fix for something that isn't working as intended backport PR backports a change from main to a named release. labels May 29, 2024
@bmtcril
Copy link
Contributor Author

bmtcril commented May 29, 2024

Removed the help text from this ticket, it'll be a whole other thing

@Ian2012
Copy link
Contributor

Ian2012 commented May 29, 2024

The following things would also need translation:

  • Charts.params.groupby.label
  • Dashboards.position.*.meta.sliceNameOverride

This would require:

  • allowing the extracting script to fetch those values
  • once those are in place, inject it on the translated assets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. bug Report of or fix for something that isn't working as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants