fix: Data too long for column 'resource_id'

[shadinaif]

when the course id is a little bit long, the lti xblock id becomes too long for resource_id to handle

To reproduce:

• Create a course with long ID. For example: course-v1:Public+TEST_IT_01+TEST_IT_01_Dec_2023
• Add lti_consumer in Advanced settings for the course
• Try to add an LTI component in the course with version 1.3
• The unit crashes
  

we tried that on the latest https://sandbox.openedx.org

[openedx-webhooks]

Thanks for the pull request, @shadinaif!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-unmaintained. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[shadinaif]

For your review @OmarIthawi, please

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (83fa9e0) to head (c5851e6).

❗ Current head c5851e6 differs from pull request most recent head f6fbae4. Consider uploading reports for the commit f6fbae4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   97.83%   97.85%   +0.01%     
==========================================
  Files          77       78       +1     
  Lines        6710     6709       -1     
==========================================
  Hits         6565     6565              
+ Misses        145      144       -1     

Flag	Coverage Δ
unittests	97.85% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[OmarIthawi]

Thanks @shadinaif please update the following:

• version: https://github.com/openedx/xblock-lti-consumer/blob/master/lti_consumer/__init__.py
• changelog: https://github.com/openedx/xblock-lti-consumer/blob/master/CHANGELOG.rst

[shadinaif]

please check now @OmarIthawi

[OmarIthawi]

Thanks Shadi. One more thing please.

[OmarIthawi]

Looks good to me. Thanks @shadinaif!!

[mphilbrick211]

Hi @OmarIthawi and @shadinaif! Is this pull request still needed?

[OmarIthawi]

Yes @mphilbrick211, we needed it to get merged but it wasn't triaged since Jan 25th.

@shadinaif there's a new changelog update that conflicts with this pull request, kindly rebase and fix it.

[shadinaif]

Rebased. But codecov is failing for no reason ¯\(ツ)/¯

[mphilbrick211]

Hi @shadinaif and @OmarIthawi! Can this be closed?

[OmarIthawi]

Thanks @shadinaif. @mphilbrick211, this is now ready for merging. I don't have permissions though. Could you please help?

[itsjeyd]

@shadinaif @OmarIthawi Sorry for the delay here. Is this PR still needed?

@shadinaif If so, could you please resolve merge conflicts?

Once the build is green we can have someone from Axim engineering merge the PR.

[OmarIthawi]

yes it's still needed @itsjeyd

[itsjeyd]

Got it, thanks @OmarIthawi.

@shadinaif Over to you for now. Let me know when you're done resolving merge conflicts here.