Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/tyndp url #1085

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Hotfix/tyndp url #1085

merged 3 commits into from
Jan 18, 2023

Conversation

nesnoj
Copy link
Member

@nesnoj nesnoj commented Jan 17, 2023 •
edited
Loading

Fixes broken URL to TYNDP scenario dataset.
Came up here: #377 (comment)

I assign this to you @AmeliaNadal @ClaraBuettner @IlkaCu as I dunno who is responsible..

Over and out.

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

@nesnoj nesnoj added the 🐛 bug Something isn't working label Jan 17, 2023
@nesnoj nesnoj mentioned this pull request Jan 17, 2023
Open
AmeliaNadal
AmeliaNadal approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@AmeliaNadal AmeliaNadal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix solves the problem (succeful locally and in the CI run) and can be merged.

@nesnoj nesnoj assigned nesnoj and unassigned IlkaCu, ClaraBuettner and AmeliaNadal Jan 18, 2023
@nesnoj nesnoj merged commit 0f6fd2e into dev Jan 18, 2023
@nesnoj nesnoj deleted the hotfix/tyndp_url branch January 18, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmeliaNadal AmeliaNadal AmeliaNadal approved these changes

@IlkaCu IlkaCu Awaiting requested review from IlkaCu

@ClaraBuettner ClaraBuettner Awaiting requested review from ClaraBuettner

Assignees

@nesnoj nesnoj

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nesnoj @AmeliaNadal @IlkaCu @ClaraBuettner