-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tibber] Crash at midnight, fetching of new data stops #13417
Comments
@seime: I have also experienced some incidents where the reconnect attempts stop for some reason, but have never seen log results as yours, getting And this mechanism of the binding is also the reason why the binding remains Online. Meaning, as the binding both covers regular queries (Tibber subscription) as well as live measurements (Tibber Pulse), the intention has been to keep the binding Online as long as the regular queries are responsive, allowing continuous attempts (as part of refresh interval) to reconnect live measurements. Will continue to chase for the reason why the reconnect attempts stop. |
Thanks for looking into this. I set the log level to debug after a few incidents where my water boiler would stay off for longer periods of time, causing cold morning showers and all-time low WAF ;). I used to rely on the (price) I think sometimes the binding is able to reconnect, but there are also a few warnings in the log - including another exception lately. I cannot tell whether this error is consistent in any way as I've only recently started to notice. I'm still adding new things to openHAB (including developing new bindings etc), and therefore I tend to restart openHAB every now and then when I hit snags. My logs are now at TRACE with a notification if data gets stale. I'll add more logs if I notice this again.
(once of the warns):
|
Appreciate the log updates. Will continue chasing my own logs as well. The IO Exceptions relate to the query part of the binding, most often around hour transitions, due to delay/difficulties getting updated data from the Tibber server. The So, need to figure out why/what happens when the refresh is killed / reconnect attempts just stop. |
This issue has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/tibber-binding-hangs-when-a-new-week-starts/139308/2 |
Good catch recognising the failure as part of new week starting. I have now also experienced the same issue, getting It might appear like the Tibber API maintains the websocket session at all other times than at the week transition, thus enabling the Tibber binding to reconnect as part of the refresh intervals. The As part of refresh interval, trying to reconnect, the binding is trying to get a verification of successful reconnect/websocket establishment, i.e. So, will have a look at rewriting the verification part, and see if this will enable reconnects also at week transitions. |
Just created a new version for testing on my own behalf. If others would be interested in trying before doing an official PR: The change to the binding relates to the verification part, to check if the websocket session actually becomes open as part of reconnect attempts (seems to be the reason causing NPE and termination of scheduled reconnect attempts around week transitions)). Now, the binding will still check if the websocket client is active, but should now manage to only log a warning if the client is not recognised as active, and thus avoid |
Thanks @kjoglum, I will test the new version. Experienced this again this night, so it appears to be a midnight problem and not just Sun/Mon.
|
Same thing happened to me last night. I have just installed the new version. Thanks @kjoglum |
Fix appears to be working, have not noticed it going offline since updating to the latest version. Thanks @kjoglum |
This issue has been mentioned on openHAB Community. There might be relevant details there: |
Log shows refreshing happens every 5 minutes as configured. At midnight errors occur. Guessing on Tibbers side, but the problem is that the binding can't deal with these and gives up while still reporting "online".
Expected behaviour: Thing goes offline and reconnect is attempted after some time
Setup: Pi4b with Pulse dongle. 2 homes in tibber, but only 1 active.
Running Openhab 3.3.0 with tibber binding patch (see #13416), line numbering therefore off
The text was updated successfully, but these errors were encountered: