Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[evcc] Add support of heating devices and three new channels #16378

Merged
merged 5 commits into from
Feb 19, 2024
Merged

[evcc] Add support of heating devices and three new channels #16378

merged 5 commits into from
Feb 19, 2024

Conversation

MikeTheTux
Copy link
Contributor

@MikeTheTux MikeTheTux commented Feb 5, 2024 •
edited
Loading

Implementation of #15744

If the charger is a heating device (no car), the SOC channels shall use Number:Temperature instead of Number:Dimensionless (Percent).

Parameter in evcc.yaml:
chargers.heating: true

Flag in API:
274711022-7a1c9f1d-928d-4047-95cc-36677c7022e9

In GUI:
274709885-356399c9-e9c1-4980-a94c-683503c47ba9

See also the following change in evcc: evcc-io/evcc#9393

Following changes have been implemented:

  • added effectiveLimitSoC, chargerFeatureHeating and chargerFeatureIntegratedDevice channels
  • support of heating devices (temperature) in addition to vehicles (SoC)

@MikeTheTux
added effectiveLimitSoC, chargerFeatureHeating and chargerFeatureInte…
7edffa6 
…gratedDevice channels

support of heating devices (temperature) in addition to vehicles (SoC)

Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux
Copy link
Contributor Author

Following changes have been implemented:

  • added effectiveLimitSoC, chargerFeatureHeating and chargerFeatureIntegratedDevice channels
  • support of heating devices (temperature) in addition to vehicles (SoC)

@MikeTheTux
remove channels that are known to be invalid (heating-channels for ve…
6edc6ca 
…hicles and the other way around)

Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux
added version and availableVersion
12fbcfa 
Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux
Copy link
Contributor Author

Following changes have been implemented:

  • added version, and availableVersion channels

lsiepel
lsiepel requested changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some naming suggestions, hope they make sense, otherwise LGTM.
Can you also summerize the functional changes in the start post for clarity and update the PR title ?

edit: late comment, some temperature channel has min/max 0/100 probably from percent? That has a different meaning in celsius vs fahrenheit, was it intentionally limited that way?

bundles/org.openhab.binding.evcc/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.evcc/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.evcc/src/main/resources/OH-INF/thing/thing-types.xml Show resolved Hide resolved
bundles/org.openhab.binding.evcc/src/main/resources/OH-INF/thing/thing-types.xml Show resolved Hide resolved
bundles/org.openhab.binding.evcc/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Feb 18, 2024
@MikeTheTux
review findings
1e995bb 
Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux MikeTheTux changed the title [evcc] Temperature instead of Percent for heating devices [evcc] Support of heating devices (°C) in addition to vehicles (%) + 3 new channels Feb 18, 2024
@MikeTheTux
Copy link
Contributor Author

edit: late comment, some temperature channel has min/max 0/100 probably from percent? That has a different meaning in celsius vs fahrenheit, was it intentionally limited that way?

In evcc, the support of heating devices is quite rudimentary. SoC (0...100%) was translated to Temperature in °C (0...100°C).
°F is not supported, see defaults.yaml#L345.
The API supports values between 0 and 100 for both - SoC (%) and Temperature (°C). Therefore I would assume that current min/max is fine.

@MikeTheTux
Copy link
Contributor Author

@lsiepel. Thanks for the review! All comments have been addressed.

@lsiepel lsiepel changed the title [evcc] Support of heating devices (°C) in addition to vehicles (%) + 3 new channels [evcc] Add support of heating devices and three new channels Feb 18, 2024
@MikeTheTux
review findings
e75bc40 
Signed-off-by: Michael Weger <[email protected]>
lsiepel
lsiepel approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Anything to add @florian-h05 ?

@florian-h05
Copy link
Contributor

Nothing to add 👍
Thanks for reviewing @lsiepel and thanks for the PR @MikeTheTux! I'm glad someone keeps up with the regular (and often breaking) evcc API changes!

@lsiepel lsiepel merged commit f0f9cf9 into openhab:main Feb 19, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Feb 19, 2024
@florian-h05 florian-h05 mentioned this pull request Feb 19, 2024
Closed
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@MikeTheTux @austvik
[evcc] Add support of heating devices and three new channels (openhab…
0734ff5 
…#16378)

* added effectiveLimitSoC, chargerFeatureHeating and chargerFeatureIntegratedDevice channels
support of heating devices (temperature) in addition to vehicles (SoC)

Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
florian-h05 pushed a commit to florian-h05/openhab-addons that referenced this pull request May 30, 2024
@MikeTheTux @florian-h05
[evcc] Add support of heating devices and three new channels (openhab…
d7ea627 
…#16378)

* added effectiveLimitSoC, chargerFeatureHeating and chargerFeatureIntegratedDevice channels
support of heating devices (temperature) in addition to vehicles (SoC)

Signed-off-by: Michael Weger <[email protected]>
(cherry picked from commit f0f9cf9)
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/evcc-binding-electric-vehicle-charging-control-backport-4-1-0-4-2-0/135209/1

joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@MikeTheTux @joni1993
[evcc] Add support of heating devices and three new channels (openhab…
cbc6778 
…#16378)

* added effectiveLimitSoC, chargerFeatureHeating and chargerFeatureIntegratedDevice channels
support of heating devices (temperature) in addition to vehicles (SoC)

Signed-off-by: Michael Weger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@florian-h05 florian-h05 Awaiting requested review from florian-h05 florian-h05 is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeTheTux @florian-h05 @openhab-bot @lsiepel