Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jetty 10.x (or Jetty 11.x) #3315

Open
joakime opened this issue Jan 13, 2023 · 14 comments
Open

Upgrade to Jetty 10.x (or Jetty 11.x) #3315

joakime opened this issue Jan 13, 2023 · 14 comments
Labels
awaiting external dependency Depends on a new version of an external dependency

Comments

@joakime
Copy link

joakime commented Jan 13, 2023

Jetty 9.x is now at End of Community Support.

You should be using Jetty 10.x (or newer) at this point.

@J-N-K
Copy link
Member

J-N-K commented Jan 13, 2023

We are currently upgrading Karaf to 4.4.3 with PaxWeb 8.0.15 (i.e. Jetty 9.4.50). There is some work on Karaf 4.5.x which will support PaxWeb 9 and Jetty 10 (https://lists.apache.org/thread/4lwbt9g0w707zomnq6cfx179n8w90d3h) but we'll have to check when we see a release there.

@J-N-K J-N-K added the awaiting external dependency Depends on a new version of an external dependency label Jan 13, 2023
@wborn
Copy link
Member

wborn commented Mar 22, 2023

The upgrade in Karaf is tracked by issue KARAF-7544.

@jlaur
Copy link
Contributor

jlaur commented Aug 27, 2023

I was checking release notes in relation to #3770 and saw this: https://issues.apache.org/jira/browse/CXF-8764. So for this library we are now at Jetty 10? So we are now bundling both Jetty 9 and 10 because of this dependency? Is it possible in the same way to decouple the dependency for PaxWeb, so that we can use Jetty 10 at the same time as PaxWeb still uses Jetty 9?

@J-N-K
Copy link
Member

J-N-K commented Aug 27, 2023

No, we currently only ship Jetty 9, as far as I can see we don't use the bundles that require jetty 10.

We could try if we can upgrade to PaxWeb 9 after Karaf 4.4 (because then we have SLF4J 2.0 available).

@joakime
Copy link
Author

joakime commented Aug 27, 2023

BTW, Jetty 12 was released. (with support for EE8 at java.servlet, EE9 at jakarta.servlet, and EE10 at jakarta.servlet at the same time)

Jetty's own tests use PaxWeb for each of these environments.

@lolodomo
Copy link
Contributor

Any idea what will be required to change in bindings when moving to Jetty 10 ?

@J-N-K
Copy link
Member

J-N-K commented Apr 13, 2024

From my understanding moving to Jetty 10 (PaxWeb 9) only requires adjustments for websockets, see https://eclipse.dev/jetty/documentation/jetty-10/programming-guide/index.html#pg-migration.

@lolodomo
Copy link
Contributor

Ok, we could then search in code for all the classes that have to be renamed.

@andrewfg
Copy link
Contributor

andrewfg commented Apr 13, 2024

^ FWIW when I wrote the Hue API v2 binding, I had to use quite low level HTTP2 code from Jetty 9.x because 10.x was not available. I am guessing that if OH shifts to Jetty 10 that low level code will not be broken. However there may be some opportunity to optimise the binding with newer Jetty 10 higher level features. This observation is fairly hypothetical. But I would look at it in detail once we get the first snapshots with Jetty 10..

@jlaur
Copy link
Contributor

jlaur commented Apr 13, 2024

Probably there will also be some things to be sorted out with dependencies, i.e. Karaf requiring Jetty 9 (Upgrade to Jetty 10 and Pax Web 9)?

@J-N-K
Copy link
Member

J-N-K commented Apr 13, 2024

Correct, well upgrade when Karaf upgrades, and I think this is scheduled for Karaf 4.5.0.

@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/unifi-binding-beta-3-2-0-3-6-0/131156/181

@joakime
Copy link
Author

joakime commented Oct 10, 2024

This issue has been open long enough that Jetty 10 and Jetty 11 are now at End of Community Support.

Jetty 12 is the only supported version of Jetty at this point in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting external dependency Depends on a new version of an external dependency
Projects
None yet
Development

No branches or pull requests

7 participants