Upgrade Xtext/Xtend to 2.32.0, LSP4J to 0.21.0 #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades Xtext and its dependencies to: * Xtext/Xtend 2.32.0 * LSP4J 0.21.0 * GSON 2.10.1 * Guava 32.1.2 * Guice 7.0.0 For release notes, see: https://eclipse.dev/Xtext/releasenotes.html#/releasenotes/2023/08/27/version-2-32-0 Fixes openhab#3321 Signed-off-by: Wouter Born <[email protected]>
This was referenced Oct 1, 2023
wborn
added
enhancement
This was referenced Oct 1, 2023
Closed
kaikreuzer
added
rebuild
|
I've uploaded the new GSON library to artifactory. |
kaikreuzer
added
rebuild
|
@wborn - thanks for this upgrade! |
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Oct 4, 2023
AFAIK these annotations are not used when using declaritive services. I stubled upon these annotations when feature validation failed while creating openhab#3817. Xtext now uses Guice 7 which is using jakarta.inject imports. Only si.uom:si-units:2.1 still imports javax.inject but it will also switch to jakarta.inject when 2.2 gets released. Signed-off-by: Wouter Born <[email protected]>
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Oct 4, 2023
AFAIK these annotations are not used when using declarative services. I stubled upon these annotations when feature validation failed while creating openhab#3817. Xtext now uses Guice 7 which is using jakarta.inject imports. Only si.uom:si-units:2.1 still imports javax.inject but it will also switch to jakarta.inject when 2.2 gets released. Signed-off-by: Wouter Born <[email protected]>
kaikreuzer
pushed a commit
that referenced
this pull request
Oct 4, 2023
AFAIK these annotations are not used when using declarative services. I stubled upon these annotations when feature validation failed while creating #3817. Xtext now uses Guice 7 which is using jakarta.inject imports. Only si.uom:si-units:2.1 still imports javax.inject but it will also switch to jakarta.inject when 2.2 gets released. Signed-off-by: Wouter Born <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Xtext and its dependencies to:
For release notes, see:
https://eclipse.dev/Xtext/releasenotes.html#/releasenotes/2023/08/27/version-2-32-0
Fixes #3321
Because LSP4J imports com.google.gson.internal this Eclipse Orbit bundle should be added to the openHAB Maven repo:
https://download.eclipse.org/tools/orbit/downloads/drops/R20230531010532/repository/plugins/com.google.gson_2.10.1.v20230109-0753.jar