Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Fix unit determination for min/max from item state description #2894

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Dec 3, 2024

Concerns the Colortemperaturepiucker element.

Concerns the Colortemperaturepiucker element.

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo added bug Something isn't working basic ui Basic UI labels Dec 3, 2024
@lolodomo lolodomo requested a review from kaikreuzer as a code owner December 3, 2024 11:34
@andrewfg
Copy link

andrewfg commented Dec 3, 2024

@lolodomo to be honest, I do not support this; it is a kludge; we need to add a proper range unit to the state descriptions

@lolodomo
Copy link
Contributor Author

lolodomo commented Dec 3, 2024

we need to add a proper range unit to the state descriptions

Of course but it is probably too late for OH 4.3. So I propose something working well for OH 4.3, our priority.
When something better is available in OH core, of course I will adjust Basic UI.

So see this fix as required for OH 4.3 until a better solution is implemented and merged n core framework.

@lolodomo lolodomo changed the title [BasicUI] Fix unit determination for min/max from state description [BasicUI] Fix unit determination for min/max from item state description Dec 3, 2024
Copy link

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..with the proviso that we should revisit this code once core 4432 is done .. LGTM :)

@kaikreuzer kaikreuzer merged commit d6cc341 into openhab:main Dec 7, 2024
5 checks passed
@kaikreuzer kaikreuzer added this to the 4.3 milestone Dec 7, 2024
@lolodomo lolodomo deleted the basicui_colortemp_minmax_unit branch December 7, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants